[Bug 1067445] Review Request: pyghmi - Python General Hardware Management Initiative

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1067445



--- Comment #4 from Christopher Meng <cickumqt@xxxxxxxxx> ---
1. pyghmi URL:

https://github.com/stackforge/pyghmi

2. %{__python} --> %{__python2}

3. %{python_sitelib} --> %{python2_sitelib}

(In reply to James Slagle from comment #1)
> Hi, I'm doing an unofficial review.

Unofficial review doesn't mean that you can do the review carelessly.

> Python:
> [x]: Python eggs must not download any dependencies during the build process.
> [x]: A package which is used by another package via an egg interface should
>      provide egg info.
> [x]: Package meets the Packaging Guidelines::Python
> [x]: Binary eggs must be removed in %prep

https://fedoraproject.org/wiki/Packaging:Python#Packaging_eggs_and_setuptools_concerns

Please remove the bundled egg.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]