[Bug 1066707] Review Request: libwfd - A stand-alone implementation of the Wifi-Display protocol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1066707



--- Comment #1 from Michael Schwendt <bugs.michael@xxxxxxx> ---
Just a brief look at the spec:


> Version:       0.0

Where does this "0.0" come from? Is it a convention explained in documentation? 

Simply using "Version: 0" is more than enough for software that hasn't had a
release yet. The extra .0 doesn't add any value.


> Release:       0.1git%{shortcommit}%{?dist}

You want a combination of "snapshot" and "pre-release",

  https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
 
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages

resulting in

  Release: 0.%{X}.%{checkout}%{?dist}

with checkout=YYYYMMDDgit%{shortcommit} and X being the most-significant
release value for normal package updates.


> %package devel
> Summary: Development package for opus

opus? ;-)


> Requires: libwfd = %{version}-%{release}

https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]