https://bugzilla.redhat.com/show_bug.cgi?id=1067445 Mark McLoughlin <markmc@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lmartins@xxxxxxxxxx Flags| |needinfo?(lmartins@redhat.c | |om) --- Comment #2 from Mark McLoughlin <markmc@xxxxxxxxxx> --- The URL tag seems wrong to me? I'd use either of: https://github.com/stackforge/pyghmi https://pypi.python.org/pypi/pyghmi Looking at the build requires: BuildRequires: python-devel https://fedoraproject.org/wiki/Packaging:Python#BuildRequires suggests using python2-devel BuildRequires: python-pbr Yep, 'python setup.py build' needs this BuildRequires: python-subunit BuildRequires: python-setuptools BuildRequires: python-testrepository These are only needed for 'python setup.py testr' and we're not doing that. So, I think you can drop those. As for runtime requires: Requires: python-pbr pyghmi does not have runtime need for pbr. Nova does because of the nova.version module, but that doesn't apply here. Requires: python-crypto >= 2.6 That's fine It looks like upstream supports python 2 and 3, so we could build a python3 sub-package ... I'm fine with leaving that for later, though. I think you should build a -doc subpackage though, see how I did it in http://pkgs.fedoraproject.org/cgit/python-oslo-messaging.git/tree/python-oslo-messaging.spec I'd like this: %{python_sitelib} to be more specific e.g. %files %{python_sitelib}/pyghmi %{python_sitelib}/*.egg-info This is wrong :) * Wed Mar 13 2013 Lucas Alvares Gomes <lucasagomes@xxxxxxxxx> - 0.5.8-1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review