https://bugzilla.redhat.com/show_bug.cgi?id=1063039 Mo Morsi <mmorsi@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mmorsi@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |mmorsi@xxxxxxxxxx Flags| |fedora-review? --- Comment #1 from Mo Morsi <mmorsi@xxxxxxxxxx> --- Taking this one. Couple of preliminary things: - this depends on rubygem-http_parser.rb which isn't in Fedora, that will need to be built & pushed before this can be officially built in koji. Will wait till we sort out that gem before running the builds for this - There seems to be an extraneous %gem_install in the %check section, please remove - Please consider rm'ing the directories which you currently %exclude in the file list. Would result in a much cleaner / consolidated files list - Upstream indicates the project is licensed under the MIT license in the README but there is no separate license file. Please file an issue w/ the upstream project to include this https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text - Note while it doesn't directly impact this gem, this upstream issue is related: https://github.com/igrigorik/em-websocket/pull/110 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review