https://bugzilla.redhat.com/show_bug.cgi?id=1066573 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #3 from Christopher Meng <cickumqt@xxxxxxxxx> --- 1. Release: 4 No %?dist 2. Systemd requires missing: Requires(post): systemd Requires(preun): systemd Requires(postun): systemd 3. %setup -q -n %{name}-%{version} just %setup -q is fine. (not an issue) 4. We don't recommend using macros for commands without special reasons(different python versions with different macros defines), so you'd better change %{__mkdir_p} to mkdir -p directly, also applies to %{__install} macro. 5. No slash needed after %{buildroot} macro, please remove. 6. cp pki/* %{buildroot}/%{_sysconfdir}/pki/taskd/. Better add -a option. 7. %pre section needs improvement: https://fedoraproject.org/wiki/Packaging:UsersAndGroups#Dynamic_allocation 8. Please use * for manpages in %files: %{_mandir}/man1/taskd.1.gz %{_mandir}/man5/taskdrc.5.gz to %{_mandir}/man1/taskd.1* %{_mandir}/man5/taskdrc.5* 9. Systemd scriptlets missing: https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd 10. rpmlint results: Rpmlint (installed packages) ---------------------------- # rpmlint taskd taskd.i686: W: spelling-error Summary(en_US) multi -> mulch, mufti taskd.i686: W: spelling-error %description -l en_US multi -> mulch, mufti taskd.i686: W: only-non-binary-in-usr-lib taskd.i686: W: non-standard-uid /etc/pki/taskd/README taskd taskd.i686: W: non-standard-gid /etc/pki/taskd/README taskd taskd.i686: E: non-readable /etc/pki/taskd/README 0750L taskd.i686: E: non-standard-executable-perm /etc/pki/taskd/README 0750L taskd.i686: E: executable-marked-as-config-file /etc/pki/taskd/README taskd.i686: E: script-without-shebang /etc/pki/taskd/README taskd.i686: W: non-standard-uid /var/lib/taskd/orgs taskd taskd.i686: W: non-standard-gid /var/lib/taskd/orgs taskd taskd.i686: E: non-standard-dir-perm /var/lib/taskd/orgs 0750L taskd.i686: W: non-standard-uid /var/lib/taskd taskd taskd.i686: W: non-standard-gid /var/lib/taskd taskd taskd.i686: E: non-standard-dir-perm /var/lib/taskd 0750L taskd.i686: W: non-standard-uid /etc/pki/taskd/generate.client taskd taskd.i686: W: non-standard-gid /etc/pki/taskd/generate.client taskd taskd.i686: E: non-readable /etc/pki/taskd/generate.client 0750L taskd.i686: E: non-standard-executable-perm /etc/pki/taskd/generate.client 0750L taskd.i686: E: executable-marked-as-config-file /etc/pki/taskd/generate.client taskd.i686: W: non-standard-uid /etc/pki/taskd taskd taskd.i686: W: non-standard-gid /etc/pki/taskd taskd taskd.i686: E: non-standard-dir-perm /etc/pki/taskd 0750L taskd.i686: W: non-standard-uid /etc/pki/taskd/generate.crl taskd taskd.i686: W: non-standard-gid /etc/pki/taskd/generate.crl taskd taskd.i686: E: non-readable /etc/pki/taskd/generate.crl 0750L taskd.i686: E: non-standard-executable-perm /etc/pki/taskd/generate.crl 0750L taskd.i686: E: executable-marked-as-config-file /etc/pki/taskd/generate.crl taskd.i686: W: non-standard-uid /etc/pki/taskd/generate.server taskd taskd.i686: W: non-standard-gid /etc/pki/taskd/generate.server taskd taskd.i686: E: non-readable /etc/pki/taskd/generate.server 0750L taskd.i686: E: non-standard-executable-perm /etc/pki/taskd/generate.server 0750L taskd.i686: E: executable-marked-as-config-file /etc/pki/taskd/generate.server taskd.i686: W: non-standard-uid /etc/pki/taskd/generate taskd taskd.i686: W: non-standard-gid /etc/pki/taskd/generate taskd taskd.i686: E: non-readable /etc/pki/taskd/generate 0750L taskd.i686: E: non-standard-executable-perm /etc/pki/taskd/generate 0750L taskd.i686: E: executable-marked-as-config-file /etc/pki/taskd/generate taskd.i686: W: non-standard-uid /etc/pki/taskd/generate.ca taskd taskd.i686: W: non-standard-gid /etc/pki/taskd/generate.ca taskd taskd.i686: E: non-readable /etc/pki/taskd/generate.ca 0750L taskd.i686: E: non-standard-executable-perm /etc/pki/taskd/generate.ca 0750L taskd.i686: E: executable-marked-as-config-file /etc/pki/taskd/generate.ca taskd.i686: W: non-standard-uid /var/log/taskd taskd taskd.i686: W: non-standard-gid /var/log/taskd taskd taskd.i686: E: non-standard-dir-perm /var/log/taskd 0750L taskd.i686: E: script-without-shebang /usr/lib/systemd/system/taskd.service taskd.i686: W: non-standard-uid /var/lib/taskd/config taskd taskd.i686: W: non-standard-gid /var/lib/taskd/config taskd taskd.i686: E: non-readable /var/lib/taskd/config 0750L taskd.i686: E: non-standard-executable-perm /var/lib/taskd/config 0750L taskd.i686: E: executable-marked-as-config-file /var/lib/taskd/config taskd.i686: E: script-without-shebang /var/lib/taskd/config taskd.i686: W: log-files-without-logrotate /var/log/taskd taskd.i686: W: no-manual-page-for-binary taskdctl taskd.i686: W: install-file-in-docs /usr/share/doc/taskd/INSTALL 1 packages and 0 specfiles checked; 28 errors, 28 warnings. ------------------ Please double check above, issues found. 11. License check: MIT/X11 (BSD like) ------------------ taskd-1.0.0/scripts/profile.py taskd-1.0.0/src/Color.cpp taskd-1.0.0/src/Color.h taskd-1.0.0/src/ConfigFile.cpp taskd-1.0.0/src/ConfigFile.h taskd-1.0.0/src/Database.cpp taskd-1.0.0/src/Database.h taskd-1.0.0/src/Date.cpp taskd-1.0.0/src/Date.h taskd-1.0.0/src/Directory.cpp taskd-1.0.0/src/Directory.h taskd-1.0.0/src/Duration.cpp taskd-1.0.0/src/Duration.h taskd-1.0.0/src/File.cpp taskd-1.0.0/src/File.h taskd-1.0.0/src/JSON.cpp taskd-1.0.0/src/JSON.h taskd-1.0.0/src/Log.cpp taskd-1.0.0/src/Log.h taskd-1.0.0/src/Msg.cpp taskd-1.0.0/src/Msg.h taskd-1.0.0/src/Nibbler.cpp taskd-1.0.0/src/Nibbler.h taskd-1.0.0/src/Path.cpp taskd-1.0.0/src/Path.h taskd-1.0.0/src/RX.cpp taskd-1.0.0/src/RX.h taskd-1.0.0/src/Server.cpp taskd-1.0.0/src/Server.h taskd-1.0.0/src/TLSClient.cpp taskd-1.0.0/src/TLSClient.h taskd-1.0.0/src/TLSServer.cpp taskd-1.0.0/src/TLSServer.h taskd-1.0.0/src/Task.cpp taskd-1.0.0/src/Task.h taskd-1.0.0/src/Thread.cpp taskd-1.0.0/src/Thread.h taskd-1.0.0/src/Timer.cpp taskd-1.0.0/src/Timer.h taskd-1.0.0/src/admin.cpp taskd-1.0.0/src/api.cpp taskd-1.0.0/src/client.cpp taskd-1.0.0/src/config.cpp taskd-1.0.0/src/daemon.cpp taskd-1.0.0/src/diag.cpp taskd-1.0.0/src/en-US.h taskd-1.0.0/src/help.cpp taskd-1.0.0/src/i18n.h taskd-1.0.0/src/init.cpp taskd-1.0.0/src/status.cpp taskd-1.0.0/src/taskd.cpp taskd-1.0.0/src/taskd.h taskd-1.0.0/src/text.cpp taskd-1.0.0/src/text.h taskd-1.0.0/src/tls/TLSClient.cpp taskd-1.0.0/src/tls/TLSClient.h taskd-1.0.0/src/tls/TLSServer.cpp taskd-1.0.0/src/tls/TLSServer.h taskd-1.0.0/src/utf8.cpp taskd-1.0.0/src/utf8.h taskd-1.0.0/src/util.cpp taskd-1.0.0/src/util.h Unknown or generated -------------------- taskd-1.0.0/cmake.h taskd-1.0.0/commit.h taskd-1.0.0/src/tls/c.cpp taskd-1.0.0/src/tls/s.cpp taskd-1.0.0/src/wcwidth6.cpp 12. Koji: warning: File listed twice: /etc/pki/taskd/README warning: File listed twice: /etc/pki/taskd/generate warning: File listed twice: /etc/pki/taskd/generate.ca warning: File listed twice: /etc/pki/taskd/generate.client warning: File listed twice: /etc/pki/taskd/generate.crl warning: File listed twice: /etc/pki/taskd/generate.server warning: File listed twice: /usr/share/doc/taskd warning: File listed twice: /usr/share/doc/taskd/AUTHORS warning: File listed twice: /usr/share/doc/taskd/COPYING warning: File listed twice: /usr/share/doc/taskd/ChangeLog warning: File listed twice: /usr/share/doc/taskd/INSTALL warning: File listed twice: /usr/share/doc/taskd/NEWS warning: File listed twice: /var/lib/taskd/orgs Please rm %{buildroot}%{_datadir}/doc/taskd/ in %install and use %doc, currently I can see INSTALL even appears in the docdir, no such need to do that. Suggestion: %doc AUTHORS COPYING ChangeLog NEWS README 13. Systemd unit file: Documentation=http://tasktools.org/projects/taskd.html You should also add the manpages. 14. You forgot to own itself: %{_sysconfdir}/pki/taskd/ 15. Why do we need this: %{_sysconfdir}/pki/taskd/README ************************************************ Requires -------- taskd (rpmlib, GLIBC filtered): /bin/bash /bin/sh config(taskd) libc.so.6 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgnutls.so.28 libgnutls.so.28(GNUTLS_1_4) libgnutls.so.28(GNUTLS_2_10) libgnutls.so.28(GNUTLS_2_12) libgnutls.so.28(GNUTLS_3_1_0) libm.so.6 libpthread.so.0 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libuuid.so.1 libuuid.so.1(UUID_1.0) rtld(GNU_HASH) Provides -------- taskd: config(taskd) taskd taskd(x86-32) Source checksums ---------------- http://taskwarrior.org/download/taskd-1.0.0.tar.gz : CHECKSUM(SHA256) this package : 162ef1eec48f8145870ef0dbe0121b78a6da99815bc18af77de07fbb0abe02d0 CHECKSUM(SHA256) upstream package : 162ef1eec48f8145870ef0dbe0121b78a6da99815bc18af77de07fbb0abe02d0 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/bin/fedora-review -rvn taskd-1.0.0-4.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review