https://bugzilla.redhat.com/show_bug.cgi?id=1062921 --- Comment #2 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> --- (In reply to Adam Williamson from comment #1) > - Large documentation must go in a -doc subpackage. Large could be size > (~1MB) > or number of files. > Note: Documentation size is 21104640 bytes in 19 files. > See: > http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation > > This one should probably block the review. As the examples are large, we > should probably split them into a -examples subpackage or something. I didn't notice that 21MB file in there! The examples have been sub-packaged. > - "Package functions as described": I gave this a pass, but as this is > principally for OwnCloud's benefit, can you please backport this commit: > https://github.com/google/google-api-php-client/commit/ > c6949531d2399f81a5e15caf256f156dd68e00e9 , as without it, OC will not work > entirely correctly. Backported > - A few files without explicit licenses: given the 'tarball-wide' LICENSE > file I think we don't need to block on this, but one of us should file an > issue upstream pointing out that the follow files are missing license blocks: > > examples/index.php > examples/templates/base.php > src/Google/Collection.php > src/Google/Model.php > src/Google/Service/Exception.php > tests/bootstrap.php I'm sleepy and off to bed. I can file this later on unless you want to take care of it today. Update diff: https://github.com/siwinski/rpms/commit/27e5a66e93d8e57308e6587425b8007202dc2094 Spec URL: https://raw2.github.com/siwinski/rpms/27e5a66e93d8e57308e6587425b8007202dc2094/php-google-apiclient.spec SRPM URL: http://siwinski.fedorapeople.org/SRPMS/php-google-apiclient-1.0.3-0.2.beta.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review