[Bug 1067015] Review Request: instack-undercloud - Install an OpenStack undercloud via python-instack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1067015



--- Comment #2 from Steven Dake <sdake@xxxxxxxxxx> ---
James,
Elements are installed in the wrong place.

For an example check out:
https://github.com/sdake/fedora-reviews/blob/master/openstack-heat-templates/openstack-heat-templates.spec#L39

Header isn't aligned - possible mixing of spaces and tabs

If your going to use a git commit without a tarball, please mark it properly in
the spec file.  For an example, see:
https://github.com/sdake/fedora-reviews/blob/master/openstack-heat-templates/openstack-heat-templates.spec#L7

Make sure to run the spec file, rpm file, and srpm file through rpmlint and fix
any problems.

I'll provide a more thorough review once you submit a new package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]