[Bug 1066629] Review Request: openstack-tripleo - OpenStack TripleO

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1066629



--- Comment #2 from Steven Dake <sdake@xxxxxxxxxx> ---
James,

I haven't taken a look at the SRPM, but these problems pop out from the spec
file.

1)
Python packages need specific BuildRequires:
https://fedoraproject.org/wiki/Packaging:Python#BuildRequires

I'd add python-setuptools for good measure

2)
The installation process is wrong.  Please use the python installer to install
packages.  For an example, check out:

https://github.com/sdake/fedora-reviews/blob/master/os-collect-config/os-collect-config.spec#L39

3)
The git snapshotting used in the spec file is wrong and does not offer a
seamless upgrade process for users.  Please use a version of 0 and release of
0.1.snapshot.dist.  For an example check out:
com/sdake/fedora-reviews/blob/master/openstack-heat-templates/openstack-heat-templates.spec#L7

4)
Alignment is likely a mix of tabs and spaces.  Recommend sticking to tabs and
aligning things on the nearest boundary that makes sense

5)
the %files section is wrong.  If something is commented out, that means the
package doesn't work as you expect - recommend fixing.

6)
Recommend %doc any LICENSE or README

7) did you run the spec file, SRPM, and RPM through rpmlint and fix the
resulting problems?

Regards
-steve

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]