https://bugzilla.redhat.com/show_bug.cgi?id=1058163 --- Comment #7 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- OK, a few more items, and I think we're close to golden: 8. MUST fix dir ownership, currently, you include: %files common ## assets: models, shaders, textures %{_datadir}/glmark2/models/* %{_datadir}/glmark2/shaders/* %{_datadir}/glmark2/textures/* but then nothing owns %{_datadir}/glmark2 %{_datadir}/glmark2/models/ %{_datadir}/glmark2/shaders/ %{_datadir}/glmark2/textures/ either switch to just: %{_datadir}/glmark2/ or add %dir %{_datadir}/glmark2/ %dir %{_datadir}/glmark2/models/ %dir %{_datadir}/glmark2/shaders/ %dir %{_datadir}/glmark2/textures/ 9. SHOULD remove redundant .desktop file stuff in %check. desktop-file-install run in %install section already validates stuff while it installs 10. SHOULD consider adding transitive dep in -common: Requires: %{name} = %{version}-%{release} unless this content is useful beyond this package, where users may have a use-case to have this -common subpkg installed without the associated binaries 11. MUST remove bundled libraries, prior to building src/libjpeg-turbo src/libpng I'd suggest adding to %prep, right after %setup, rm -rv src/libjpeg-turbo src/libpng See also: https://fedoraproject.org/wiki/Packaging:Treatment_Of_Bundled_Libraries 12. SHOULD consider moving 'waf configure' to %build stage. I don't think we have any waf-specific guideline about this, but it feels akin to autoconf's ./configure to me, and this fits better in %build licensing: ok licensecheck -r glmark2-2012.12 | cut -d: -f2 | sort -u GPL (v3 or later) MIT/X11 (BSD like) looks like you could even do GPLv3+ here, but if upstream's intend is to be GPLv3-only, that takes precedence. sources: ok, verified 4f306664aa3886fa0cf93853603603f8 glmark2-2012.12.tar.gz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review