https://bugzilla.redhat.com/show_bug.cgi?id=1060386 Alec Leamas <leamas.alec@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |leamas.alec@xxxxxxxxx --- Comment #5 from Alec Leamas <leamas.alec@xxxxxxxxx> --- Hi, and welcome! Now, since this is your first package here are two things: you need to improve your package, and to get sponsored. As for improving your package some points out of the top of my head: - The installation is quite messy. This seems to be because you have to do it more or less from scratch in the spec file. Applications like this normally has an installer script which can do something like "make install DESTDIR=$RPM_BUILD_ROOT". It would probably be better to patch your already existing installer to respect a DESTDIR argument or environment variable (if it doesn't already support this) and use it in the %install section. This would clean up the spec considerably, and use already proven code to install. - You don't really understand how rpm works e. g., when upgrading and tries to duplicate it's behaviour. This will break expectations. In short, trust how rpm upgrades files, also in /etc. It's enough if you mark them as %config files. - As an example, the long %post section could probably be (almost?) skipped. All files and dirs should be installed in %install, and enabling a service during installation is not allowed. - You can certainly run fedora-review yourself as a preparation for the review. The manpage describes how to add the required group to your user (don't paste the results into the ticket, though - that's the reviewer's task). But to me, what looks like the hard part is to get sponsored (no, I'm not a sponsor myself). In order to get sponsored you need to look into [1]. In particular, you need to look into other reviews and make remarks. By looking at other reviews (and remarks from others!) you will get a better understanding of both the guidelines and the process. For now, I think it might make sense to focus on this; it will eventually make you update your package in many ways beyond my remarks. As a starter, you can find other open review requests at [2] [1] https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group [2] http://fedoraproject.org/PackageReviewStatus/NEW.html -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review