https://bugzilla.redhat.com/show_bug.cgi?id=1064656 --- Comment #5 from Will Benton <willb@xxxxxxxxxx> --- (In reply to marcindulak from comment #3) > in fact there was only one clearly "bundled" library (apart from erf) used > by elk: fftw. > BLAS and LAPACK were compiled but not used - i removed the source dirs > in %prep and modified the makefile to show this explicitly. libxc was not > bundled (in a sense being included in the elk source an compiled and linked > as such), but elk included some fortran modules from libxc for interface > purposes. > > I have switched to libxc-devel provided fortran modules, at the cost of > having -I%{_fmoddir} in gfortran compilation options. I switched also to > fftw3. Thanks for making these changes! (Packages do need to delete bundled source in %prep even if it is not linked in as part of the build; see: http://fedoraproject.org/wiki/Packaging:Treatment_Of_Bundled_Libraries) As far as NPROC goes, it is probably OK to define it as 2, or to extract a number out from %{_smp_mflags} as Susi Lehtola suggests (which would give you 3 on a uniprocessor machine), or to define it as export NPROC=$(cat /proc/cpuinfo | grep -c processor) or whatever; it's a matter of taste. I am double-checking everything else and will finish the review when I have. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review