https://bugzilla.redhat.com/show_bug.cgi?id=908088 --- Comment #8 from Antonio Trande <anto.trande@xxxxxxxxx> --- (In reply to Rex Dieter from comment #7) > A few initial comments: > > 1. SHOULD drop deprecated rpm constructs, including Group: tags (unless > you plan on supporting building on/for epel-5) > > > 2. SHOULD give script or detailed instructions on how to (re)generate > Source0 archive > > > 3. MUST use > BuildRequires: python2-devel > and associated macros %{python2_sitelib} %{python2_sitearch} macros per > https://fedoraproject.org/wiki/Packaging:Python > > > 4. MUST drop unwanted deps > Requires(post): desktop-file-utils shared-mime-info > Requires(postun): desktop-file-utils shared-mime-info > see also: > https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database > https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo Well, this package was also created for RHEL5, but now needs packages which are not in EPEL. Fixed. > > > 5. MUST fix icon scriptlets. > stuff referencing %{_datadir}/icons/hicolor is ok, but not > %{_datadir}/icons. in short, drop the lines: > touch --no-create %{_datadir}/icons &>/dev/null > gtk-update-icon-cache %{_datadir}/icons &>/dev/null || : > gtk-update-icon-cache %{_datadir}/icons &>/dev/null || : Fixed. > > > 6. MUST review/fix folder ownership. Offhand, it would appear nothing owns > %{models}/ (expands to %{_libdir}/ascend/models) > %{models}/sensitivity/ > %{johnpye}/ (expands to %{_libdir}/ascend/models/johnpye) > %{johnpye}/grena/ > %{johnpye}/extpy/ > %{johnpye}/extfn/ > %{johnpye}/datareader/ > ... > you should get the idea. Ops! Important inattention. Fixed. > > > 7. SHOULD consider a -libs subpkg for > %{_libdir}/libascend.so.* > This is mostly to be multilib friendly, as anything matching > %{_libdir}/lib*.so.* will get multilib'd automatically (e.g. pkg.i686 will > get pulled into x86_64 repo). All libraries packaged in a -libs sub-package. Spec URL: http://sagitter.fedorapeople.org/ascend/ascend.spec SRPM URL: http://sagitter.fedorapeople.org/ascend/ascend-0.9.8-3.20140211svn4638.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review