[Bug 1065745] Review Request: lltag - tag music files comfortably

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1065745



--- Comment #6 from Leon Weber <leon@xxxxxxxxxxxx> ---
You’re mixing tabs and spaces for indention in the spec file, e.g.

  8 Source0:        http://download.gna.org/lltag/lltag-0.14.4.tar.bz2
  9 Patch1:     lltag-prefix.patch

Line 8 uses spaces while line 9 uses tabs. That’s why it looks unaligned in my
editor. It would be better to keep it consistent.

It’s recommended to put the version tag in the source URL, so that it doesn’t
have to be changed with every version bump:

http://download.gna.org/lltag/lltag-%{version}.tar.bz2

(You could even replace lltag with %{name}.)

make doesn’t need to be specified in the BuildRequires (see
<https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires> for a list
of exceptions).

Changelog still missing a version tag, see
<https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs> for valid
formats.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]