https://bugzilla.redhat.com/show_bug.cgi?id=1065745 Leon Weber <leon@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |leon@xxxxxxxxxxxx --- Comment #2 from Leon Weber <leon@xxxxxxxxxxxx> --- Some issues (this is an **INFORMAL** review): - Summary should not end in a dot - License should be GPLv2+ instead of GPL - Source0 should contain the full URL of the source tarball - It would be nicer to format the spec file in a way that all tag values are lined up in one colum - The description field has a trailing whitespace - The %files section should be using macros instead of hardcoded paths - Put upstream’s COPYING, Changes and README files in a %doc directory - %changelog section must have the package version, and should have a (non-empty) entry (e.g. “First version for Fedora”) Please read <http://fedoraproject.org/wiki/How_to_create_an_RPM_package> as an introduction and <https://fedoraproject.org/wiki/Packaging:Guidelines> for full guidelines. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review