Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-HTML-Encoding - Determine the encoding of HTML/XML/XHTML documents Alias: perl-HTML-Encoding https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234814 ------- Additional Comments From cweyl@xxxxxxxxxxxxxxx 2007-04-02 12:27 EST ------- Please ensure release is bumped to 1 before building :) Aside from that, looks ready... + source files match upstream: ee31564305ffdaf24d99f26588f8eb9f HTML-Encoding-0.52.tar.gz ee31564305ffdaf24d99f26588f8eb9f ../HTML-Encoding-0.52.tar.gz + package meets naming and versioning guidelines. O specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible; license text not included upstream. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package installs properly O no debuginfo package -- noarch + rpmlint is silent. + final provides and requires are sane: ** perl-HTML-Encoding-0.52-0.5.fc6.noarch.rpm == rpmlint == provides perl(HTML::Encoding) = 0.52 perl-HTML-Encoding = 0.52-0.5.fc6 == requires perl(:MODULE_COMPAT_5.8.8) perl(Encode) perl(HTML::Parser) perl(HTTP::Headers::Util) perl(base) perl(strict) perl(warnings) + %check is present and all tests pass: All tests successful. Files=1, Tests=1, 0 wallclock secs ( 0.04 cusr + 0.02 csys = 0.06 CPU) + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + no headers. + no pkgconfig files. + no libtool .la droppings. + not a GUI app. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review