Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: samba https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226387 ------- Additional Comments From dmitry@xxxxxxxxxxxx 2007-04-02 11:45 EST ------- Against 3.0.24-10: - What about "auth" macro? Why the explicit or implicit "Requires: pam >= ..." could not be enough? - Certainly "samba" subpackage must require "samba-common". For the current rpm program, "Requires(pre): something" implies an ordinary "Requires: something" too, but to be more robast, add explicit "Requires: samba-common = ...." anyway, notwithstanding of "...(pre)" existence. - Whether "samba-doc" actually requires "samba-common"? - Replace "/usr/lib", "/usr/lib*" just to %{_libdir} - Changelog section still has "macros" (since 21 May 2001 and to EOF) - It seems to be more useful to move "docs/registry" from "-docs" to the main subpackage. - All the docs/manpages contain non-ascii non-UTF8 symbols. Moreover, it looks not like a "national symbol in author's name", it could be some formatting mess. Do "iconv -f UTF-8 < nmbd.8" for example. - Init scripts: there is no need to check for /etc/rc.d/init.d/finctions existence. (f.e. httpd and vsftpd do not such an extra check). - winbind.init: /var/lock/subsys name should match the initscript name, i.e. should be "/var/lock/subsys/winbind", not ".../winbindd" (rmplint complains about it). Since "/var/cache/samba" is no more used, maybe create a symlink to /var/lib/samba? Perhaps this way (old and new places are playing together) the migration procedure could be simplified... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review