https://bugzilla.redhat.com/show_bug.cgi?id=1024779 --- Comment #7 from Christopher Meng <cickumqt@xxxxxxxxx> --- (In reply to Louis Lagendijk from comment #6) > Thanks for the feedback Christopher, > Re 1. First question, do we need to follow SUSE's way of handling plugins? I > don't agree with the packaging here, one -plugins package is enough. > > I moved a number of plugins into the main package. I left the evolution > address book as it has dependencies on all the evolution libs, I wanted to > avoid havng to pull in all that stuff when not required. > I am fine with pulling all the notification plugins into the main package. > The status icon does not work on Gnome 3, so it might be better to keep that > separate too and explain the reason why. Yes. > You mean make libroutermanager its own package and have both > libroutermanager and roger-router packages build from the same tar-ball? > What is the advantage of that? They are both in the same tar-ball, so > keeping it this way is less work in maintaining the packages. I have started > a discussion with upstream on properly versioning libroutermanager-libs. > That will hopefully come in the near future. Ah no, actually I would include the libraries provided in the main package or -libs subpackages, but never split the library out and make it as separate libXXX package since I think this library is useful for this software only. But anything could happen, so I'm not sure on this package. > Re 7: yes: 78 is defined in //usr/share/doc/setup/uidgid as the predefined > gid for fax. Is there anything wrong with re-using that gid? No. > Re 8: will check if this can be easily done. I left this as I did not want > to deviate from what upstream uses. If you feel that it is incorrect I can > modify the upstream Makefile.am to skip the plugin specific directories. But > is it worth changing the upstream defaults? No, I mean write one line for files is OK, you can try by yourself. RPM do include the files in subdirectories.(personal habit here in other words) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review