https://bugzilla.redhat.com/show_bug.cgi?id=1059805 --- Comment #1 from Will Benton <willb@xxxxxxxxxx> --- Thanks for packaging this, Rob! There are a few problems to address. Issues and notes: ================= * There is some bundled code included in the project; see below for details. Upstream asserts that this code is forked and modified. If it is substantially modified, it is only likely to be useful to greenmail (since the bundled libraries are taken from actual mail servers, not mock mail servers), which is a good sign for a potential bundling exception. You should evaluate whether or not an FPC bundling exception is appropriate (see https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Modified_beyond_a_certain_extent for more particulars) and apply for one if you deem it is. * Why aren't you using the 1.3.1b zip file available from the upstream web site? If it's the same as r75 from the source repository, then the upstream archive is preferable. If it's not the same, then it probably shouldn't be called 1.3.1b. See https://fedoraproject.org/wiki/Packaging:SourceURL for guidelines, but note that the upstream archive, with a canonical URL, is the preferred Source: tag value unless otherwise impossible or impractical. * The licensing situation is a little confused; many of the bundled and forked source files claim to be licensed under the LGPL, but the license.txt says Apache. I have filed a ticket upstream for clarification: https://sourceforge.net/p/greenmail/bugs/8/ * There is no %check, but the tests are run as part of mvn_rpmbuild. However, it seems like there are many spurious warnings and failures in one of the tests (com.icegreen.greenmail.test.MultiRequestTest). Please investigate whether or not it is worth patching this test to work well in Fedora builds. A list of apparently-bundled code and annotated fedora-review output follows. On the positive side, the spec is very simple and clean and everything builds successfully in koji (http://koji.fedoraproject.org/koji/taskinfo?taskID=6527098). Suspicious/bundled code: ======================= Code apparently forked from Foedus: * src/java/com/icegreen/greenmail/foedus/util/StringBufferResource.java * src/java/com/icegreen/greenmail/foedus/util/StreamUtils.java * src/java/com/icegreen/greenmail/foedus/util/Resource.java * src/java/com/icegreen/greenmail/foedus/util/Workspace.java * src/java/com/icegreen/greenmail/foedus/util/InMemoryWorkspace.java * src/java/com/icegreen/greenmail/foedus/util/MsgRangeFilter.java * src/java/com/icegreen/greenmail/smtp/SmtpHandler.java * src/java/com/icegreen/greenmail/smtp/SmtpServer.java * src/java/com/icegreen/greenmail/smtp/SmtpConnection.java * src/java/com/icegreen/greenmail/smtp/commands/RsetCommand.java * src/java/com/icegreen/greenmail/smtp/commands/VrfyCommand.java * src/java/com/icegreen/greenmail/smtp/commands/NoopCommand.java * src/java/com/icegreen/greenmail/smtp/commands/QuitCommand.java * src/java/com/icegreen/greenmail/smtp/commands/SmtpCommandRegistry.java * src/java/com/icegreen/greenmail/smtp/commands/SmtpCommand.java * src/java/com/icegreen/greenmail/smtp/commands/HeloCommand.java * src/java/com/icegreen/greenmail/smtp/commands/MailCommand.java * src/java/com/icegreen/greenmail/smtp/commands/DataCommand.java * src/java/com/icegreen/greenmail/smtp/commands/RcptCommand.java * src/java/com/icegreen/greenmail/smtp/SmtpManager.java * src/java/com/icegreen/greenmail/smtp/SmtpState.java * src/java/com/icegreen/greenmail/mail/MailException.java * src/java/com/icegreen/greenmail/mail/MailAddress.java * src/java/com/icegreen/greenmail/mail/MovingMessage.java * src/java/com/icegreen/greenmail/mail/MalformedAddressException.java * src/java/com/icegreen/greenmail/pop3/commands/PassCommand.java * src/java/com/icegreen/greenmail/pop3/commands/UidlCommand.java * src/java/com/icegreen/greenmail/pop3/commands/StatCommand.java * src/java/com/icegreen/greenmail/pop3/commands/NoopCommand.java * src/java/com/icegreen/greenmail/pop3/commands/DeleCommand.java * src/java/com/icegreen/greenmail/pop3/commands/QuitCommand.java * src/java/com/icegreen/greenmail/pop3/commands/ApopCommand.java * src/java/com/icegreen/greenmail/pop3/commands/Pop3CommandRegistry.java * src/java/com/icegreen/greenmail/pop3/commands/RetrCommand.java * src/java/com/icegreen/greenmail/pop3/commands/Pop3Command.java * src/java/com/icegreen/greenmail/pop3/commands/ListCommand.java * src/java/com/icegreen/greenmail/pop3/commands/TopCommand.java * src/java/com/icegreen/greenmail/pop3/commands/UserCommand.java * src/java/com/icegreen/greenmail/pop3/Pop3State.java * src/java/com/icegreen/greenmail/pop3/Pop3Connection.java * src/java/com/icegreen/greenmail/pop3/Pop3Server.java * src/java/com/icegreen/greenmail/pop3/Pop3Handler.java * src/java/com/icegreen/greenmail/user/UserException.java * src/java/com/icegreen/greenmail/user/UserManager.java * src/java/com/icegreen/greenmail/user/UserImpl.java * src/java/com/icegreen/greenmail/user/NoSuchUserException.java Code apparently forked from Apache James: * src/java/com/icegreen/greenmail/util/ServerSetupTest.java * src/java/com/icegreen/greenmail/store/MailFolder.java * src/java/com/icegreen/greenmail/store/Store.java * src/java/com/icegreen/greenmail/store/InMemoryStore.java * src/java/com/icegreen/greenmail/store/SimpleStoredMessage.java * src/java/com/icegreen/greenmail/store/StoredMessage.java * src/java/com/icegreen/greenmail/store/MailMessageAttributes.java * src/java/com/icegreen/greenmail/store/SimpleMessageAttributes.java * src/java/com/icegreen/greenmail/store/MessageFlags.java * src/java/com/icegreen/greenmail/store/FolderException.java * src/java/com/icegreen/greenmail/store/FolderListener.java * src/java/com/icegreen/greenmail/imap/ImapSessionImpl.java * src/java/com/icegreen/greenmail/imap/ProtocolException.java * src/java/com/icegreen/greenmail/imap/ImapRequestHandler.java * src/java/com/icegreen/greenmail/imap/AuthorizationException.java * src/java/com/icegreen/greenmail/imap/commands/ExpungeCommand.java * src/java/com/icegreen/greenmail/imap/commands/LoginCommand.java * src/java/com/icegreen/greenmail/imap/commands/RenameCommand.java * src/java/com/icegreen/greenmail/imap/commands/StoreCommand.java * src/java/com/icegreen/greenmail/imap/commands/ImapCommandFactory.java * src/java/com/icegreen/greenmail/imap/commands/CheckCommand.java * src/java/com/icegreen/greenmail/imap/commands/CommandParser.java * src/java/com/icegreen/greenmail/imap/commands/UidEnabledCommand.java * src/java/com/icegreen/greenmail/imap/commands/UnsubscribeCommand.java * src/java/com/icegreen/greenmail/imap/commands/CloseCommand.java * src/java/com/icegreen/greenmail/imap/commands/SelectedStateCommand.java * src/java/com/icegreen/greenmail/imap/commands/NoopCommand.java * src/java/com/icegreen/greenmail/imap/commands/IdSet.java * src/java/com/icegreen/greenmail/imap/commands/CreateCommand.java * src/java/com/icegreen/greenmail/imap/commands/FetchCommand.java * src/java/com/icegreen/greenmail/imap/commands/StatusCommand.java * src/java/com/icegreen/greenmail/imap/commands/CommandTemplate.java * src/java/com/icegreen/greenmail/imap/commands/ExamineCommand.java * src/java/com/icegreen/greenmail/imap/commands/AppendCommand.java * src/java/com/icegreen/greenmail/imap/commands/NonAuthenticatedStateCommand.java * src/java/com/icegreen/greenmail/imap/commands/AuthenticatedStateCommand.java * src/java/com/icegreen/greenmail/imap/commands/UidCommand.java * src/java/com/icegreen/greenmail/imap/commands/LogoutCommand.java * src/java/com/icegreen/greenmail/imap/commands/LsubCommand.java * src/java/com/icegreen/greenmail/imap/commands/ImapCommand.java * src/java/com/icegreen/greenmail/imap/commands/IdRange.java * src/java/com/icegreen/greenmail/imap/commands/CapabilityCommand.java * src/java/com/icegreen/greenmail/imap/commands/AuthenticateCommand.java * src/java/com/icegreen/greenmail/imap/commands/MsnRange.java * src/java/com/icegreen/greenmail/imap/commands/SearchCommand.java * src/java/com/icegreen/greenmail/imap/commands/ListCommand.java * src/java/com/icegreen/greenmail/imap/commands/SubscribeCommand.java * src/java/com/icegreen/greenmail/imap/commands/SelectCommand.java * src/java/com/icegreen/greenmail/imap/commands/CopyCommand.java * src/java/com/icegreen/greenmail/imap/commands/DeleteCommand.java * src/java/com/icegreen/greenmail/imap/ImapServer.java * src/java/com/icegreen/greenmail/imap/ImapRequestLineReader.java * src/java/com/icegreen/greenmail/imap/ImapSessionFolder.java * src/java/com/icegreen/greenmail/imap/ImapHostManagerImpl.java * src/java/com/icegreen/greenmail/imap/ImapHostManager.java * src/java/com/icegreen/greenmail/imap/ImapConstants.java * src/java/com/icegreen/greenmail/imap/ImapSessionState.java * src/java/com/icegreen/greenmail/imap/ImapSession.java * src/java/com/icegreen/greenmail/imap/ImapHandler.java * src/java/com/icegreen/greenmail/imap/ImapResponse.java fedora-review output ==================== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. * both of the licenses that this package is putatively distributed under are open-source licenses [!]: License field in the package spec file matches the actual license. * as above, there is some confusion about which license upstream means to apply to the project. [x]: License file installed when any subpackage combination is installed. [!]: Package contains no bundled libraries without FPC exception. * see details above [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 4 files. [!]: Package complies to the Packaging Guidelines * see concerns about Source: tags and upstream archives above [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) [x]: Bundled jar/class files should be removed before build Maven: [-]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Pom files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in greenmail- javadoc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. * it's documented, but please don't use it! :-) [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. * as above, there's no %check, but the tests are run as part of the build. All indicate that they pass, but one has some fishy warnings. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: greenmail-1.3.1b-1.fc21.noarch.rpm greenmail-javadoc-1.3.1b-1.fc21.noarch.rpm greenmail-1.3.1b-1.fc21.src.rpm greenmail.src: W: invalid-url Source0: greenmail-1.3.1b.tar.gz 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint greenmail-javadoc greenmail 2 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- greenmail-javadoc (rpmlib, GLIBC filtered): jpackage-utils greenmail (rpmlib, GLIBC filtered): java jpackage-utils mvn(javax.mail:mail) mvn(org.slf4j:slf4j-api) Provides -------- greenmail-javadoc: greenmail-javadoc greenmail: greenmail mvn(com.icegreen:greenmail) Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1059805 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, SugarActivity, Perl, R, PHP, Ruby Disabled flags: EPEL5, EXARCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review