https://bugzilla.redhat.com/show_bug.cgi?id=1001452 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(cickumqt@xxxxxxxx | |m) | --- Comment #2 from Christopher Meng <cickumqt@xxxxxxxxx> --- (In reply to Björn Persson from comment #1) > The source URL is invalid. There is no version 2.0.98.3.1 on the server. > Please fix this so I can know which version I'm reviewing. That was a development version. Updated. > To match what LICENSE says, the License field should be "GPLv2+ or Artistic". Done. > If I understand correctly, "touch .test_done" ignores any and all failures > in the whole test suite. That makes the %check section rather pointless. Why > run the tests at all if you're going to ignore the result? If the > "makeppreplay" test is known to fail, wouldn't it be better to disable only > that one test? Enabled again. > Anyway, I don't believe that test case has anything to do with Ccache. I > can't see that anything in Makepp invokes Ccache, and it fails with the same > error message whether I have Ccache installed or not. Not it invokes that, but the gcc actually maybe(haven't checked again) I will provide new links later as something unexpected happened. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review