https://bugzilla.redhat.com/show_bug.cgi?id=1064455 --- Comment #4 from Vinzenz Feenstra [evilissimo] <vfeenstr@xxxxxxxxxx> --- Thanks for the review so far :-) (In reply to Christopher Meng from comment #2) > I find no reason of naming it as godot-engine, please name it as godot only. ok I will rename it. (In reply to Christopher Meng from comment #3) > SCON is a buildsystem? IMO it's bullshit. If you have the power, please > persuade upstream to use CMake. Yes, scons is a build system ( http://scons.org/ ). But I don't think that this would be an easier undertaking to make them move to cmake any time soon. There was a request for them to move to waf (which is a fork of scons) https://github.com/okamstudio/godot/issues/15 Considering the relatively little time this project is open source, they have to get used to how work out how to handle all those pull requests. > 1. LDFLAGS not inserted, please take a look at %__global_ldflags I missed that, thanks for pointing that out. > 2. GODOT_BUILTIN_ZLIB=no > GODOT_DDS=no > GODOT_DEFAULT_GUI_THEME=yes > GODOT_DISABLE_3D=no > GODOT_DISABLE_ADVANCED_GUI=no > GODOT_FREETYPE=yes > GODOT_JPEG=yes > GODOT_LUA=no > GODOT_MINIZIP=yes > GODOT_MUSEPACK=yes > GODOT_NEDMALLOC=yes > GODOT_OLD_SCENES=yes > GODOT_OPENGL=yes > GODOT_PNG=yes > GODOT_PVR=yes > GODOT_PYTHON=no > GODOT_SCRIPT=yes > GODOT_SPEEX=yes > GODOT_SQUIRREL=no > GODOT_SQUISH=no > GODOT_THEORA=yes > GODOT_TOOLS=yes > GODOT_VORBIS=yes > GODOT_WEBP=yes > GODOT_XML=yes > > Any explanation of the no items? Ah yeah see, I missed that, I had that previously but due to some building issues I switched the way how I did it and scrapped the comments in the process :( There are 3 reasons, either it's a deprecated feature (such as squirrel and lua) unnecessary for the build at all (GODOT_PYTHON), or problematic due to potential patents (DDS and SQUISH) I will put the comments back. > 3. Bundled code should be rm -rf to ensure the purity, but I haven't tested > if it will make scon become a brat. The patch removes it, it needs a bit more fine picking, since they have their own files for the plugins using the libraries in the same folder as the code of the libraries. Even worse is that they rejected my pull request for allowing dynamic linking See here: https://github.com/okamstudio/godot/pull/51 > 4. install -m 0755 -d %{buildroot}/%{_docdir}/%{name} > install -m 0755 -d %{buildroot}/%{_bindir} > install -m 0755 ./bin/godot_rel %{buildroot}/%{_bindir}/godot > install -m 0755 ./bin/godot_server %{buildroot}/%{_bindir}/godot_server > > No slash between %buildroot and other macros; OK > No -p option to preserve the timestamp; OK > Why did you mkdir the %_pkgdocdir? And then %doc in %files with nothing? When I did that I thought I can put something there, however in the end it turned out that there's not much I was able to do for now. From what I know the documentation is builtin the binary. It's the runtime for games and at the same time an editor which has built-in help. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review