https://bugzilla.redhat.com/show_bug.cgi?id=1024779 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@xxxxxxxxx --- Comment #5 from Christopher Meng <cickumqt@xxxxxxxxx> --- Can you rename the spec to: http://fazant.net/roger-router/roger-router.spec? --------------------- 1. First question, do we need to follow SUSE's way of handling plugins? I don't agree with the packaging here, one -plugins package is enough. I strongly discourage packagers looking at other distro's specs since sometimes they are just a waste of time, plus incorrect for Fedora. If I ask you to write a SPEC from scratch, will you split out the library libroutermanager? 2. Please move %global lines to the top(well actually you can move to almost anywhere, but it's a good habit) 3. Please cleanup spec carefully, LGPLv2.+ is what license? 4. {buildroot}/%{_datadir} --> {buildroot}%{_datadir}, applies to others 5. %{_var} --> %{_localsatedir} 6. find , -exec rm -f {} ';' lines --> find , -delete -print 7. %pre getent group fax > /dev/null || groupadd -f -g 78 -r fax Are you sure? 8. %dir %{_libdir}/roger/ %dir %{_libdir}/roger/plugins Fedora doesn't have the problem, just %{_libdir}/roger/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review