Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Bio-ASN1-EntrezGene - Regular expression-based Perl Parser for NCBI Entrez Gene Alias: Bio-ASN1-Entrez https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234571 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-04-02 05:51 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url fabb888e03435007e08050def1aed0ac Bio-ASN1-EntrezGene-1.091.tgz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test disabled for circular BR on perl-bioperl + Provides: perl(Bio::ASN1::EntrezGene) = 1.09 perl(Bio::ASN1::EntrezGene::Indexer) = 1.09 perl(Bio::ASN1::Sequence) = 1.09 perl(Bio::ASN1::Sequence::Indexer) = 1.09 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review