https://bugzilla.redhat.com/show_bug.cgi?id=1062315 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flags| |fedora-review? --- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Looks like spec is written using some existing old xorg package spec Review:- + Mock build is successful for f21 x86_64 + rpmlint on generated rpms gave output xorg-x11-drv-fbturbo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/xf86-video-fbturbo-0.4.0/src/g2d_driver.h xorg-x11-drv-fbturbo-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/xf86-video-fbturbo-0.4.0/src/sunxi_disp_ioctl.h 3 packages and 0 specfiles checked; 2 errors, 0 warnings. ==> Ok + Source verified with upstream tarball as (sha256sum) upstream tarball 10411686de0a9d8b2cde300b0d68e9f1d22e3611470d357ef3afc337f123ca0f srpm tarball 10411686de0a9d8b2cde300b0d68e9f1d22e3611470d357ef3afc337f123ca0f - License is NOT valid. It should be MIT as per written in source files headers. Suggestions: 1) %define should be replaced by %global Reference -> https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define 2) group tag line is not needed now anymore Reference -> https://fedoraproject.org/wiki/:Guidelines#Group_tag 3) removing the buildroot in (first line of) %install is not needed now, remove it. Reference -> https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag 4) %clean is not needed now Reference -> https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean 5) Files installed should preserve timestamp, you can do that using make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" Reference -> https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps 6) %description can also add lines X.Org X11 fbturbo video driver, primarily optimized for the devices powered by the Allwinner SoC (A10, A13, A20). It can use some of the 2D/3D hardware acceleration features. 7) Fix license tag 8) Should contact upstream to get fsf address corrected as reported by rpmlint output. I also observed that build.log is showing following lines sh: xserver-sdk-abi-requires: command not found sh: xserver-sdk-abi-requires: command not found Package xorg-server was not found in the pkg-config search path. Perhaps you should add the directory containing `xorg-server.pc' to the PKG_CONFIG_PATH environment variable No package 'xorg-server' found I am not sure if its an issue with macro expansion in Requires: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review