https://bugzilla.redhat.com/show_bug.cgi?id=896193 --- Comment #26 from Christopher Meng <cickumqt@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2.1 or later)", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated". 34 files have unknown license. Detailed output of licensecheck: GPL (v2 or later) ----------------- plank-0.5.0/build-aux/ltmain.sh GPL (v3 or later) ----------------- plank-0.5.0/data/apport/source_plank.py plank-0.5.0/lib/DockController.vala plank-0.5.0/lib/DockPreferences.vala plank-0.5.0/lib/DockRenderer.vala plank-0.5.0/lib/DragManager.vala plank-0.5.0/lib/Drawing/AnimatedRenderer.vala plank-0.5.0/lib/Drawing/Color.vala plank-0.5.0/lib/Drawing/DockSurface.vala plank-0.5.0/lib/Drawing/DockTheme.vala plank-0.5.0/lib/Drawing/DrawingService.vala plank-0.5.0/lib/Drawing/Theme.vala plank-0.5.0/lib/Factories/AbstractMain.vala plank-0.5.0/lib/Factories/Factory.vala plank-0.5.0/lib/Factories/ItemFactory.vala plank-0.5.0/lib/HideManager.vala plank-0.5.0/lib/Items/ApplicationDockItem.vala plank-0.5.0/lib/Items/ApplicationDockItemProvider.vala plank-0.5.0/lib/Items/DefaultApplicationDockItemProvider.vala plank-0.5.0/lib/Items/DockItem.vala plank-0.5.0/lib/Items/DockItemPreferences.vala plank-0.5.0/lib/Items/DockItemProvider.vala plank-0.5.0/lib/Items/FileDockItem.vala plank-0.5.0/lib/Items/PlankDockItem.vala plank-0.5.0/lib/Items/TransientDockItem.vala plank-0.5.0/lib/PositionManager.vala plank-0.5.0/lib/Services/Logger.vala plank-0.5.0/lib/Services/Matcher.vala plank-0.5.0/lib/Services/Paths.vala plank-0.5.0/lib/Services/Preferences.vala plank-0.5.0/lib/Services/System.vala plank-0.5.0/lib/Services/WindowControl.vala plank-0.5.0/lib/Widgets/CompositedWindow.vala plank-0.5.0/lib/Widgets/DockWindow.vala plank-0.5.0/lib/Widgets/HoverWindow.vala plank-0.5.0/lib/Widgets/PoofWindow.vala plank-0.5.0/src/PlankMain.vala plank-0.5.0/tests/Drawing.vala plank-0.5.0/tests/Items.vala plank-0.5.0/tests/Main.vala plank-0.5.0/tests/Preferences.vala plank-0.5.0/tests/Widgets.vala plank-0.5.0/tests/test-config.h LGPL (v2.1 or later) -------------------- plank-0.5.0/lib/Widgets/TitledSeparatorMenuItem.vala Unknown or generated -------------------- plank-0.5.0/docs/c-doc/ccomments/AbstractMain.c plank-0.5.0/docs/c-doc/ccomments/AnimatedRenderer.c plank-0.5.0/docs/c-doc/ccomments/ApplicationDockItem.c plank-0.5.0/docs/c-doc/ccomments/ApplicationDockItemProvider.c plank-0.5.0/docs/c-doc/ccomments/Color.c plank-0.5.0/docs/c-doc/ccomments/CompositedWindow.c plank-0.5.0/docs/c-doc/ccomments/DefaultApplicationDockItemProvider.c plank-0.5.0/docs/c-doc/ccomments/DockController.c plank-0.5.0/docs/c-doc/ccomments/DockItem.c plank-0.5.0/docs/c-doc/ccomments/DockItemPreferences.c plank-0.5.0/docs/c-doc/ccomments/DockItemProvider.c plank-0.5.0/docs/c-doc/ccomments/DockPreferences.c plank-0.5.0/docs/c-doc/ccomments/DockRenderer.c plank-0.5.0/docs/c-doc/ccomments/DockSurface.c plank-0.5.0/docs/c-doc/ccomments/DockTheme.c plank-0.5.0/docs/c-doc/ccomments/DockWindow.c plank-0.5.0/docs/c-doc/ccomments/DragManager.c plank-0.5.0/docs/c-doc/ccomments/DrawingService.c plank-0.5.0/docs/c-doc/ccomments/Factory.c plank-0.5.0/docs/c-doc/ccomments/FileDockItem.c plank-0.5.0/docs/c-doc/ccomments/HideManager.c plank-0.5.0/docs/c-doc/ccomments/HoverWindow.c plank-0.5.0/docs/c-doc/ccomments/ItemFactory.c plank-0.5.0/docs/c-doc/ccomments/Logger.c plank-0.5.0/docs/c-doc/ccomments/Paths.c plank-0.5.0/docs/c-doc/ccomments/PlankDockItem.c plank-0.5.0/docs/c-doc/ccomments/PoofWindow.c plank-0.5.0/docs/c-doc/ccomments/PositionManager.c plank-0.5.0/docs/c-doc/ccomments/Preferences.c plank-0.5.0/docs/c-doc/ccomments/System.c plank-0.5.0/docs/c-doc/ccomments/Theme.c plank-0.5.0/docs/c-doc/ccomments/TitledSeparatorMenuItem.c plank-0.5.0/docs/c-doc/ccomments/TransientDockItem.c plank-0.5.0/lib/abicheck.sh [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in plank [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 143360 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: plank-0.5.0-1.fc21.i686.rpm plank-devel-0.5.0-1.fc21.i686.rpm plank-0.5.0-1.fc21.src.rpm plank.i686: W: spelling-error Summary(en_US) docky -> dock, docks, dorky plank-devel.i686: W: no-documentation plank.src: W: spelling-error Summary(en_US) docky -> dock, docks, dorky 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint plank plank-devel plank.i686: W: spelling-error Summary(en_US) docky -> dock, docks, dorky plank.i686: W: unused-direct-shlib-dependency /usr/lib/libplank.so.0.0.0 /lib/libpthread.so.0 plank-devel.i686: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 3 warnings. # echo 'rpmlint-done:' Requires -------- plank (rpmlib, GLIBC filtered): /bin/sh bamf-daemon libX11.so.6 libatk-1.0.so.0 libbamf3.so.0 libc.so.6 libcairo-gobject.so.2 libcairo.so.2 libdbusmenu-glib.so.4 libdbusmenu-gtk3.so.4 libgdk-3.so.0 libgdk_pixbuf-2.0.so.0 libgee-0.8.so.2 libgio-2.0.so.0 libglib-2.0.so.0 libgobject-2.0.so.0 libgthread-2.0.so.0 libgtk-3.so.0 libpango-1.0.so.0 libpangocairo-1.0.so.0 libplank.so.0 libpthread.so.0 libwnck-3.so.0 rtld(GNU_HASH) plank-devel (rpmlib, GLIBC filtered): /sbin/ldconfig /usr/bin/pkg-config libplank.so.0 pkgconfig(cairo) pkgconfig(gdk-3.0) pkgconfig(gdk-pixbuf-2.0) pkgconfig(gee-0.8) pkgconfig(gio-2.0) pkgconfig(glib-2.0) pkgconfig(gobject-2.0) pkgconfig(gthread-2.0) pkgconfig(gtk+-3.0) plank(x86-32) vala-tools Provides -------- plank: application() application(plank.desktop) libplank.so.0 plank plank(x86-32) plank-devel: pkgconfig(plank) plank-devel plank-devel(x86-32) Source checksums ---------------- https://launchpad.net/plank/1.0/0.5.0/+download/plank-0.5.0.tar.xz : CHECKSUM(SHA256) this package : bf0e14dbdc9d30d57e55cc88644ef6e6c296be924bbfc1b345cba1e0c9be1804 CHECKSUM(SHA256) upstream package : bf0e14dbdc9d30d57e55cc88644ef6e6c296be924bbfc1b345cba1e0c9be1804 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -rvn plank-0.5.0-1.fc20.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -------------------------- 1. valadoc is now ready for packaging, I will cleanup and then continue packaging it. But I won't set it as a blocker anymore. Bug later ;) 2. /sbin/ldconfig is not needed for devel package. 3. %{_mandir}/man1/%{name}.1.gz --> %{_mandir}/man1/%{name}.1* RPM will help you when it is uncompressed. 4. Group tag can be removed.(Not an issue) -------------------------- Please paste the new spec/srpm with fix or explanation regarding the above issues. Note that bamf will receive the update soon in rawhide, should have no affection to this package. -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review