https://bugzilla.redhat.com/show_bug.cgi?id=1016444 Volker Fröhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@xxxxxx --- Comment #3 from Volker Fröhlich <volker27@xxxxxx> --- You should BR qt4-devel. However, PyQt4-devel transitively requires qt4-devel anyway, so you can drop it. I'm not sure what the Python modules are necessary for. BR python2 is not necessary. Use the name macro for patches, use the name and version macro in URL. The spec file and the spec file from the RPM don't match. You should rather delete fst in the prep section. Please add COPYING and README as %doc. The optflags are useless there, as nothing should be compiled. Can you find a more elegant solution than symlinks? With fst only being available on i686, the build of this package should be excluded too. Will it work with Python 3? sed -i -e 's/Qt/Sequencer/' %{buildroot}%{_datadir}/applications/%{name}.desktop -- Ideally you should not edit the desktop file manually, but through the desktop utils. However, this can go to the prep section. The README file says: ----- COMPILE: In order to use FeSTige, you first have to compile it. You'll need the devel packages of: - Python - PyQt4 - Qt4 - Wine - Gtk That seems wrong and you should let the author know, if he's still active. Can you get your changes upstream? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review