Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gmediaserver - UPnP compatible media server for the GNU system Alias: gmediaserver https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221906 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium ------- Additional Comments From bjohnson@xxxxxxxxxxxx 2007-04-02 03:43 EST ------- Sorry, I've been awfully busy and haven't been able to finish this review. It will still be a couple of day yet. I did a quick look over the spec file and things look much better. There was a couple of things that stood out. 1) "%patch0 -p0 -b .mypatch" - when I said ".mypatch" I meant to personalize it. I suspect in your case it would be something like "%patch0 -p0 -b .infofix". I see you took me literally. 2) The %preun and %postun are using two different styles of testing $1. This makes it hard to read. Suggest that you adopt the style of %preun. You are also mixing different styles of redirection. This makes it a little hard to follow, but it not a blocker. 3) rpmlint will always complain with the userdel/groupdel in the scriptlets. Let me check and see what the current recommended way to handle this is. A lot of people suggest leaving the user on the system once it's created. Since it's going to own the media, we must be careful that reinstallation get the same id or there will be a problem. This might be a candidate for static uid, but let me check. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review