https://bugzilla.redhat.com/show_bug.cgi?id=1032425 --- Comment #6 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: $ diff -u perl-XML-Parser-Lite.spec{.old,} --- perl-XML-Parser-Lite.spec.old 2014-02-05 16:49:07.000000000 +0100 +++ perl-XML-Parser-Lite.spec 2014-02-06 10:37:34.000000000 +0100 @@ -1,11 +1,13 @@ Name: perl-XML-Parser-Lite Version: 0.719 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Lightweight regexp-based XML parser License: (GPL+ or Artistic) and REX Group: Development/Libraries URL: http://search.cpan.org/dist/XML-Parser-Lite/ Source0: http://www.cpan.org/authors/id/P/PH/PHRED/XML-Parser-Lite-%{version}.tar.gz +# rt#91434 +Patch0: perl-XML-Parser-Lite-0.719-tests.patch BuildArch: noarch # SOAP::Lite is not actually needed BuildRequires: perl @@ -18,7 +20,7 @@ BuildRequires: perl(Test::More) BuildRequires: perl(warnings) BuildRequires: perl(XMLRPC::Lite) -BuildRequires: perl(XMLRPC::Test) +BuildRequires: perl(XMLRPC::Test::Server) Requires: perl(:MODULE_COMPAT_%(eval "$(perl -V:version)"; echo $version)) %description @@ -28,6 +30,7 @@ %prep %setup -q -n XML-Parser-Lite-%{version} +%patch0 -p1 %build perl Makefile.PL INSTALLDIRS=vendor @@ -47,6 +50,9 @@ %{_mandir}/man3/* %changelog +* Thu Feb 06 2014 Petr Šabata <contyk@xxxxxxxxxx> - 0.719-2 +- Patch the test suite so it actually works + * Wed Feb 05 2014 Petr Šabata <contyk@xxxxxxxxxx> - 0.719-1 - 0.719 bump Source archive is original (SHA-256: 7c8c8a42bd7e6b64cd92d445132f57a6db23952741796e4764b59cb9c9011b05). Ok. The patch is Ok. > FIX: Tests do not pass in F21 (http://koji.fedoraproject.org/koji/taskinfo?taskID=6499398). See <https://rt.cpan.org/Public/Bug/Display.html?id=91434> for bug report. All tests pass. Ok. rpmlint perl-XML-Parser-Lite.spec ../SRPMS/perl-XML-Parser-Lite-0.719-2.fc21.src.rpm ../RPMS/noarch/perl-XML-Parser-Lite-0.719-2.fc21.noarch.rpm perl-XML-Parser-Lite.src: W: invalid-license REX perl-XML-Parser-Lite.noarch: W: invalid-license REX 2 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-XML-Parser-Lite-0.719-2.fc21.noarch.rpm drwxr-xr-x 2 root root 0 Feb 10 14:16 /usr/share/doc/perl-XML-Parser-Lite -rw-r--r-- 1 root root 295 Dec 2 18:43 /usr/share/doc/perl-XML-Parser-Lite/Changes -rw-r--r-- 1 root root 1159 Nov 26 19:38 /usr/share/doc/perl-XML-Parser-Lite/README -rw-r--r-- 1 root root 3351 Feb 10 14:16 /usr/share/man/man3/XML::Parser::Lite.3pm.gz drwxr-xr-x 2 root root 0 Feb 10 14:16 /usr/share/perl5/vendor_perl/XML drwxr-xr-x 2 root root 0 Feb 10 14:16 /usr/share/perl5/vendor_perl/XML/Parser -rw-r--r-- 1 root root 10762 Dec 2 18:44 /usr/share/perl5/vendor_perl/XML/Parser/Lite.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-XML-Parser-Lite-0.719-2.fc21.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(re) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. rpm -q --provides -p ../RPMS/noarch/perl-XML-Parser-Lite-0.719-2.fc21.noarch.rpm | sort | uniq -c 1 perl(XML::Parser::Lite) = 0.719 1 perl-XML-Parser-Lite = 0.719-2.fc21 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-XML-Parser-Lite-0.719-2.fc21.noarch.rpm Binary dependencies resolvable. Ok. FIX: Package does not build in F21 (http://koji.fedoraproject.org/koji/taskinfo?taskID=6512171): + make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/07-xmlrpc_payload.t .. ok # Looks like you planned 6 tests but ran 8. t/26-xmlrpc.t .......... Dubious, test returned 255 (wstat 65280, 0xff00) All 6 subtests passed (less 8 skipped subtests: -2 okay) t/27-xmlparserlite.t ... ok t/37-mod_xmlrpc.t ...... ok t/Lite.t ............... ok Test Summary Report ------------------- t/26-xmlrpc.t (Wstat: 65280 Tests: 8 Failed: 2) Failed tests: 7-8 Non-zero exit status: 255 Parse errors: Bad plan. You planned 6 tests but ran 8. Files=5, Tests=88, 2 wallclock secs ( 0.13 usr 0.02 sys + 1.51 cusr 0.11 csys = 1.77 CPU) Result: FAIL Otherwise the package is good. Please correct all `FIX' items and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review