https://bugzilla.redhat.com/show_bug.cgi?id=1062942 --- Comment #4 from Christopher Meng <cickumqt@xxxxxxxxx> --- 1. It's a good habit to move BuildRequires above Requires: 2. No need to use %{__make}, just make. 3. Remove these: rm -rf %{buildroot} find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';' %clean section %defattr(-,root,root,-) 4. If the permission is incorrect, correct it in %install, avoid %attr(0755, root, root) nowadays(or, say, always). 5. RPM can help gzip the manpages, so you can write this: %{_mandir}/man1/%{name}.1* The glob will let RPM check and finish the compressing. 6. Each time you do something of SPEC in review, please bump the Release: Release: 1%{?dist} to Release: 2%{?dist} And so forth. Also in %changelog, please bump also: * Mon Feb 10 2014 <> - 0.07-2 - Correct the issues mentioned in review(bug 1062942) * Mon Feb 10 2014 <> - 0.07-1 7. Please scratch a build in Koji, and paste the job URL to here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review