Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Return-Value - Polymorphic Return Values https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234789 rc040203@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ ------- Additional Comments From rc040203@xxxxxxxxxx 2007-04-02 01:06 EST ------- Two minor issues: 1. # rpmbuild ... ... + /usr/bin/perl Makefile.PL INSTALLDIRS=vendor WARNING: LICENSE is not a known parameter. ... => This is a minor bug inside of Makefile.PL Removing the line containing "LICENSE" would remove this warning. 2. ... t/perl-critic.....skipped all skipped: define PERL_TEST_CRITIC to run these tests ... I'd recommend to change make test into make test PERL_TEST_CRITIC=1 and to BR: perl(Test::Perl::Critic) Nevertheless, I am approving this package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review