https://bugzilla.redhat.com/show_bug.cgi?id=1062911 --- Comment #2 from Denis Fateyev <denis@xxxxxxxxxxx> --- (In reply to Volker Fröhlich from comment #1) > Did you leave out README.loconet and README.selectrix on purpose? I found them not really informative, don't remember why.. I can add them back though. > You can remove %defattr(-,root,root,-). It's not required in EPEL 5. Well, in contrary I think it can be useful for EPEL5. Guidelines says that it's no longer needed for rpm >= 4.4, but it doesn't break things either. > I think you can remove the {?el5} constructions. While the covered elements > are no longer necessary in later distribution releases, they don't do any > harm either. No, I think we can't since I'm planning to package for EPEL5. Such packages require "BuildRoot" tag,"%clean" section, and so on: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review