https://bugzilla.redhat.com/show_bug.cgi?id=875087 Paul Cochrane <paul@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo? | |needinfo?(paul@xxxxxxxxx) | --- Comment #22 from Paul Cochrane <paul@xxxxxxxxx> --- (In reply to Orion Poplawski from comment #21) > Package Review > ============== Hi Orion, my apologies for my late reply. > Issues: > ======= > - Package contains BR: python2-devel or python3-devel > You need to have BuildRequires: python2-devel Fixed in current rpms. > - Please fix the FSF address in the license. I've copied the text directly from http://www.gnu.org/licenses/gpl-2.0.txt. The address check should hopefully work now. > - It looks like cluster_status is a GUI application and as such should have > a .desktop file. I'll have to address this issue later. > - cluster_status (and perhaps even gen_nodes_file) is too generic. Please > add a pbs (or pbs_) prefix. This I will also fix later. Actually, that was the reason why I put these configuration files in /etc/pbsclusterviz.d to start with. Should I change the file names anyway? > - Drop BuildRoot and %clean unless you want to target epel5 BuildRoot and %clean have been dropped. The rpms should target epel6. > - You only need to define python_sitelib, etc if you want to target epel5. > If you do, please use the form from the guidelines: > > %if 0%{?rhel} && 0%{?rhel} <= 5 > %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from > distutils.sysconfig import get_python_lib; print(get_python_lib())")} > %{!?python_sitearch: %global python_sitearch %(%{__python} -c "from > distutils.sysconfig import get_python_lib; print(get_python_lib(1))")} > %endif Have removed python_sitelib definition. > - Your changelog versions do not match the package version "0.7" vs "0.7a". The version numbers should now match correctly. > - You need to escape "%" in %changelog entries with another %, eg %%clean %clean in changelog escaped with extra %. The SRCRPM, SPEC and distribution tarball are at the usual location: - https://github.com/paultcochrane/pbsclusterviz/releases/download/v0.7a/pbsclusterviz-0.7a-4.el6.src.rpm - https://github.com/paultcochrane/pbsclusterviz/releases/download/v0.7a/pbsclusterviz-0.7a.tar.gz - https://github.com/paultcochrane/pbsclusterviz/releases/download/v0.7a/pbsclusterviz.spec I will get around to the other issues as soon as possible. Thanks again for your help! Cheers, Paul -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review