https://bugzilla.redhat.com/show_bug.cgi?id=1061801 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #3 from Christopher Meng <cickumqt@xxxxxxxxx> --- 0. I packaged this in 1.5.5 era, but currently I'd say no, due to the horrible list of package eithor submitted or NOT submitted yet ;) Please package newer version 1.5.8.3 released 16 hours ago...... XDDD 1. All subpackages has Requires: %{name} = %{version}-%{release} but Missing %?_isa need to be appended after %{name}. 2. devel package template: %package devel Summary: Development files for %{name} Requires: %{name}%{?_isa} = %{version}-%{release} %description devel This package contains libraries and header files for developing applications that use %{name}. 3. Being as the Design softwares SIG leader, I'd say that gimp plugins need to be named as gimp-%{name}-plugin. 4. make in subdirectory? Just try make -C $(SUBDIRECTORY) --> make %{?_smp_mflags} FFMPEG_CFLAGS= FFMPEG_LDFLAGS= OPT_CFLAGS="%{optflags}" -C src/ 5. You may need to add a %configure : || in %build also for LDFLAGS since this package doesn't use configure to honor global ldflags. [rpmaker@fab SPECS]$ rpm -E %__global_ldflags -Wl,-z,relro 6. No %defattr(-,root,root) please. 7. No zart build. Please use %package -n zart to create a separate package. 8. %{_prefix}/include --> %{_includedir} 9. Add lang(fr): lang(fr) %{_mandir}/fr/man1/%{name}.1* (use glob) 10. Delete Buildroot: %{_tmppath}/%{name}-%{version}-root ** I've mailed these issues in building to upstream, hope they can work around some in the next release. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review