https://bugzilla.redhat.com/show_bug.cgi?id=783016 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|cickumqt@xxxxxxxxx | --- Comment #34 from Christopher Meng <cickumqt@xxxxxxxxx> --- My opinions again: 1. Requires: pygame,PyQt4,pybox2d Hmm.. I think for a while, and looking back to the BuildRequires field. Would you like to sort them like: Requires: pygame Requires: PyQt4 Requires: pybox2d 2. Pilas is an engine for video games quickly and easily. It is a tool designed for casual or novice programmers. who want to start making their first games. 2 space between "Pilas" and "is", please erase one. 3. Hint for this line(not an issue): find . -iname "*.Ds_Store" | xargs rm -f --> find . -iname "*.Ds_Store" -delete 4. Fedora will move to python3 totally from f22, so spec need to be reworked: sed -i 's|/usr/bin/env python|/usr/bin/python|g' --> sed -i 's|/usr/bin/env python|%{__python2}|g' 5. cp -p doc/source/images/pilas-icono.png %{buildroot}%{_datadir}/pixmaps/ Use install with -m644 to ensure the correct perms: install -pm644 doc/source/images/pilas-icono.png %{buildroot}%{_datadir}/pixmaps/ 6. mkdir -p %{buildroot}%{_datadir}/applications No need to do that IIRC, just use desktop-file-install to finish that. 7. Remove %clean, don't leave anything in the spec even itself. 8. You should add a %check section and BR python-nose to run nosetests pointed out by upstream on their github homepage, con el siguiente comando: nosetests -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review