[Bug 1062686] Review Request: libmediaart - Manage and cache media art

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1062686



--- Comment #2 from Christopher Meng <cickumqt@xxxxxxxxx> ---
I learned that xvfb may be used to supersede X for checking, not sure if it
works at here.

SPEC: 

1. %{_includedir}//libmediaart-1.0

-->

%{_includedir}/libmediaart-1.0

2. find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';'

Hint(not error): 

find $RPM_BUILD_ROOT -name '*.la' -delete

3. Summary:        Manage and cache media art

Or course it's not good. Library?Shell script?Javascript? ;)

4. %description
Library tasked with managing, extracting and handling media art caches

Missing dot at the end.

5. Being as library(am i right from the summary only? ;)), these files are not
needed for %doc in main package:

%files
%doc AUTHORS COPYING COPYING.LESSER NEWS

I'd suggest using this:

%files
%doc COPYING COPYING.LESSER

And put AUTHORS & NEWS into -devel subpackage.

BTW, 2 copying files are reduntant IMO, you can choose to leave one only here.
But this is not an issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]