https://bugzilla.redhat.com/show_bug.cgi?id=1062291 František Dvořák <valtri@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(valtri@xxxxxxxxxx | |) | --- Comment #3 from František Dvořák <valtri@xxxxxxxxxx> --- (In reply to David King from comment #2) > Only one thing needs fixing, which is to place the static libraries in a > -static subpackage. Actually these are stub libraries needed to build SW using the dll files. .dll.a files should be included in the main mingw32/mingw64 packages together with the .dll (https://fedoraproject.org/wiki/Packaging:MinGW?rd=Packaging/MinGW#Example_Specfile) > I suppose that it would be nice to carry that > improvement over to the "native" package as well. There are no static libraries in neither speex nor mingw-speex packages. Guidelines don't recommend static libraries, but permit them if there is reason for them. Many mingw packages provide static libraries, they could be added here too. But dependency mingw-libogg has also no static libraries anyway. :-) > Packaging the latest > version (1.2-0.19.rc1) would be nice, but is not a requirement. > That's only the age, I kept the version numbering from the original review (it is probably not needed, but I preserved the %changlog too...). > I really look forward to using this package while creating a MinGW build of > EasyTAG! :-) > Nice. :-) Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review