https://bugzilla.redhat.com/show_bug.cgi?id=970411 David King <amigadave@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |NotReady --- Comment #1 from David King <amigadave@xxxxxxxxxxxxx> --- Hi, I cannot give a formal review because I am not a sponsor, but I can give some informal comments: * BuildRoot is not required: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag * %clean is not required: https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean * "BuildRequires: mingw32-gcc-c++" does not seem to be needed (as there are no C++ source files) * "BuildRequires: mingw??-binutils" is not required, as it is automatically pulled in via mingw??-gcc * "Requires: pkgconfig" is not required, as it is pulled in automatically * "%defattr(-,root,root,-)" is not required: https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions * "rm -rf %{buildroot}" in %install is not required -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review