https://bugzilla.redhat.com/show_bug.cgi?id=1055799 --- Comment #4 from Robert Rati <rrati@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable Issues: ======= Need approval from FPC (https://fedorahosted.org/fpc/ticket/389) ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 119 files have unknown license. Detailed output of licensecheck in /home/fedora/1055799-sbt/licensecheck.txt [!]: Package contains no bundled libraries without FPC exception. FPC exception is currently awaiting consideration: https://fedorahosted.org/fpc/ticket/389 [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. 2 jar files included in the upstram source needed for testing (a.jar). These should be included in the FPC exception. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Only use %_sourcedir in very specific situations. Note: %_sourcedir/$RPM_SOURCE_DIR is used. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 3 files. There are no javadocs at the moment. Building the docs is currently not possible. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local Maven: [x]: POM files have correct Maven mapping Note: Some add_maven_depmap calls found. Please check if they are correct or update to latest guidelines [x]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. Tests currently aren't functional due to missing dependencies [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: sbt-0.13.1-4.fc21.noarch.rpm sbt-0.13.1-4.fc21.src.rpm sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/org.jsoup/jsoup/1.7.1/jsoup-1.7.1.jar /usr/share/java/jsoup.jar sbt.noarch: W: non-conffile-in-etc /etc/sbt/sbt.boot.properties sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/org.scala-lang/scala-library/2.10.3/scala-library-2.10.3.jar /usr/share/java/scala/scala-library.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/org.fusesource.jansi/jansi/1.9/jansi-1.9.jar /usr/share/java/jansi/jansi.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/commons-httpclient/commons-httpclient/3.0/commons-httpclient-3.0.jar /usr/share/java/jakarta-commons-httpclient.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/oro/oro/2.0.8/oro-2.0.8.jar /usr/share/java/jakarta-oro.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/org.scala-tools.sbinary/sbinary_2.10/0.4.2/sbinary_2.10-0.4.2.jar /usr/share/java/sbinary.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/org.fusesource.hawtjni/hawtjni-runtime/1.8/hawtjni-runtime-1.8.jar /usr/share/java/hawtjni/hawtjni-runtime.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/org.bouncycastle/bcpg-jdk16/1.46/bcpg-jdk16-1.46.jar /usr/share/java/bcpg.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/com.jcraft/jsch/0.1.31/jsch-0.1.31.jar /usr/share/java/jsch.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/org.bouncycastle/bcprov-jdk16/1.46/bcprov-jdk16-1.46.jar /usr/share/java/bcprov.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/com.jcraft/jsch/0.1.46/jsch-0.1.46.jar /usr/share/java/jsch.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/org.apache.ivy/ivy/2.3.0/ivy-2.3.0.jar /usr/share/java/ivy.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/org.scala-lang/scala-reflect/2.10.3/scala-reflect-2.10.3.jar /usr/share/java/scala/scala-reflect.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/net.sf.proguard/proguard-base/4.8/proguard-base-4.8.jar /usr/share/java/proguard/proguard.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/jline/jline/2.11/jline-2.11.jar /usr/share/java/jline/jline.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/org.scala-lang/scala-compiler/2.10.3/scala-compiler-2.10.3.jar /usr/share/java/scala/scala-compiler.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/org.scala-sbt/test-interface/1.0/test-interface-1.0.jar /usr/share/java/test-interface.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/org.fusesource.jansi/jansi-native/1.5/jansi-native-1.5.jar /usr/share/java/jansi-native/jansi-native.jar sbt.noarch: W: no-manual-page-for-binary sbt sbt.src: W: strange-permission sbt 0755L sbt.src:530: W: macro-in-comment %{scala_short_version} sbt.src:564: W: macro-in-comment %{scala_short_version} sbt.src:665: E: use-of-RPM_SOURCE_DIR 2 packages and 0 specfiles checked; 1 errors, 23 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint sbt sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/org.jsoup/jsoup/1.7.1/jsoup-1.7.1.jar /usr/share/java/jsoup.jar sbt.noarch: W: non-conffile-in-etc /etc/sbt/sbt.boot.properties sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/org.scala-lang/scala-library/2.10.3/scala-library-2.10.3.jar /usr/share/java/scala/scala-library.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/org.fusesource.jansi/jansi/1.9/jansi-1.9.jar /usr/share/java/jansi/jansi.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/commons-httpclient/commons-httpclient/3.0/commons-httpclient-3.0.jar /usr/share/java/jakarta-commons-httpclient.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/oro/oro/2.0.8/oro-2.0.8.jar /usr/share/java/jakarta-oro.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/org.scala-tools.sbinary/sbinary_2.10/0.4.2/sbinary_2.10-0.4.2.jar /usr/share/java/sbinary.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/org.fusesource.hawtjni/hawtjni-runtime/1.8/hawtjni-runtime-1.8.jar /usr/share/java/hawtjni/hawtjni-runtime.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/org.bouncycastle/bcpg-jdk16/1.46/bcpg-jdk16-1.46.jar /usr/share/java/bcpg.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/com.jcraft/jsch/0.1.31/jsch-0.1.31.jar /usr/share/java/jsch.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/org.bouncycastle/bcprov-jdk16/1.46/bcprov-jdk16-1.46.jar /usr/share/java/bcprov.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/com.jcraft/jsch/0.1.46/jsch-0.1.46.jar /usr/share/java/jsch.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/org.apache.ivy/ivy/2.3.0/ivy-2.3.0.jar /usr/share/java/ivy.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/org.scala-lang/scala-reflect/2.10.3/scala-reflect-2.10.3.jar /usr/share/java/scala/scala-reflect.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/net.sf.proguard/proguard-base/4.8/proguard-base-4.8.jar /usr/share/java/proguard/proguard.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/jline/jline/2.11/jline-2.11.jar /usr/share/java/jline/jline.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/org.scala-lang/scala-compiler/2.10.3/scala-compiler-2.10.3.jar /usr/share/java/scala/scala-compiler.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/org.scala-sbt/test-interface/1.0/test-interface-1.0.jar /usr/share/java/test-interface.jar sbt.noarch: W: dangling-symlink /usr/share/sbt/ivy-local/org.fusesource.jansi/jansi-native/1.5/jansi-native-1.5.jar /usr/share/java/jansi-native/jansi-native.jar sbt.noarch: W: no-manual-page-for-binary sbt 1 packages and 0 specfiles checked; 0 errors, 20 warnings. # echo 'rpmlint-done:' Requires -------- sbt (rpmlib, GLIBC filtered): /bin/sh apache-ivy javapackages-tools jline2 jpackage-utils mvn(com.jcraft:jsch) mvn(commons-httpclient:commons-httpclient) mvn(org.bouncycastle:bcpg-jdk16) mvn(org.bouncycastle:bcprov-jdk16) mvn(org.fusesource.jansi:jansi) mvn(org.jsoup:jsoup) mvn(org.scala-lang:scala-compiler) mvn(org.scala-lang:scala-library) mvn(org.scala-lang:scala-reflect) mvn(oro:oro) proguard sbinary test-interface Provides -------- sbt: mvn(org.scala-sbt:actions) mvn(org.scala-sbt:api) mvn(org.scala-sbt:apply-macro) mvn(org.scala-sbt:cache) mvn(org.scala-sbt:classfile) mvn(org.scala-sbt:classpath) mvn(org.scala-sbt:collections) mvn(org.scala-sbt:command) mvn(org.scala-sbt:compile) mvn(org.scala-sbt:compiler-integration) mvn(org.scala-sbt:compiler-ivy-integration) mvn(org.scala-sbt:completion) mvn(org.scala-sbt:control) mvn(org.scala-sbt:cross) mvn(org.scala-sbt:datatype-generator) mvn(org.scala-sbt:incremental-compiler) mvn(org.scala-sbt:interface) mvn(org.scala-sbt:io) mvn(org.scala-sbt:ivy) mvn(org.scala-sbt:launcher) mvn(org.scala-sbt:launcher-interface) mvn(org.scala-sbt:logging) mvn(org.scala-sbt:main) mvn(org.scala-sbt:main-settings) mvn(org.scala-sbt:persist) mvn(org.scala-sbt:process) mvn(org.scala-sbt:relation) mvn(org.scala-sbt:run) mvn(org.scala-sbt:sbt) mvn(org.scala-sbt:scripted-framework) mvn(org.scala-sbt:scripted-plugin) mvn(org.scala-sbt:scripted-sbt) mvn(org.scala-sbt:task-system) mvn(org.scala-sbt:tasks) mvn(org.scala-sbt:test-agent) mvn(org.scala-sbt:testing) mvn(org.scala-sbt:tracking) sbt Source checksums ---------------- https://raw.github.com/willb/climbing-nemesis/master/climbing-nemesis.py : CHECKSUM(SHA256) this package : 181ac93e126e665239836b337e964ace6a4a8800e0526de0cda28e414da0c7f3 CHECKSUM(SHA256) upstream package : 181ac93e126e665239836b337e964ace6a4a8800e0526de0cda28e414da0c7f3 https://raw.github.com/willb/sbt-packaging/master/sbt.boot.properties : CHECKSUM(SHA256) this package : f553dd5a8f429084300eb98708da538f9e7ba8a6eec4d4d09a559bb3e96107ce CHECKSUM(SHA256) upstream package : f553dd5a8f429084300eb98708da538f9e7ba8a6eec4d4d09a559bb3e96107ce http://repo1.maven.org/maven2/org/apache/ivy/ivy/2.3.0-rc1/ivy-2.3.0-rc1.pom : CHECKSUM(SHA256) this package : fc262fa4486d7d1869e17f3103c4d2de66af75e0a32ad991a2de0e2e66c1b61d CHECKSUM(SHA256) upstream package : fc262fa4486d7d1869e17f3103c4d2de66af75e0a32ad991a2de0e2e66c1b61d http://repo1.maven.org/maven2/org/apache/ivy/ivy/2.3.0-rc1/ivy-2.3.0-rc1.jar : CHECKSUM(SHA256) this package : a893166b8b9386173127f8d10f9f4ba2df421bd8f122e5317e842fc86767e7f1 CHECKSUM(SHA256) upstream package : a893166b8b9386173127f8d10f9f4ba2df421bd8f122e5317e842fc86767e7f1 https://github.com/sbt/sbt-git/archive/v0.6.3.tar.gz : CHECKSUM(SHA256) this package : b02af52c118436b72ff7b32cdef9dd364b0bcd883d24882e0014389f1e644e69 CHECKSUM(SHA256) upstream package : b02af52c118436b72ff7b32cdef9dd364b0bcd883d24882e0014389f1e644e69 https://github.com/sbt/sbt-site/archive/0.6.2.tar.gz : CHECKSUM(SHA256) this package : 44ac09e7358f2d16b65af3f880f308499902111ed451cb088b40adeb973eb592 CHECKSUM(SHA256) upstream package : 44ac09e7358f2d16b65af3f880f308499902111ed451cb088b40adeb973eb592 https://github.com/sbt/sbt/archive/v0.13.1.tar.gz : CHECKSUM(SHA256) this package : d863a1eb0a82c5859cc8cf27272c31421c71169745680c2edb8f09a9f0325c65 CHECKSUM(SHA256) upstream package : d863a1eb0a82c5859cc8cf27272c31421c71169745680c2edb8f09a9f0325c65 https://github.com/sbt/sbt-ghpages/archive/v0.5.1.tar.gz : CHECKSUM(SHA256) this package : 0b853a49846b47c1183de9ace8f91f804e409a3369ff2ca42b4bcbbd9f8f173b CHECKSUM(SHA256) upstream package : 0b853a49846b47c1183de9ace8f91f804e409a3369ff2ca42b4bcbbd9f8f173b https://github.com/rickynils/scalacheck/archive/1.11.0.tar.gz : CHECKSUM(SHA256) this package : 6fe08c4e20d52afb916783afc5e80238863d8b27ddf488c8cec07e876c964704 CHECKSUM(SHA256) upstream package : 6fe08c4e20d52afb916783afc5e80238863d8b27ddf488c8cec07e876c964704 https://github.com/etorreborre/specs2/archive/SPECS2-1.12.3.tar.gz : CHECKSUM(SHA256) this package : 665ac55c5015c63eb1f7ab895b3c609656214cccc87da93039c5336a01edd0c5 CHECKSUM(SHA256) upstream package : 665ac55c5015c63eb1f7ab895b3c609656214cccc87da93039c5336a01edd0c5 https://github.com/harrah/browse/archive/v0.3.0.tar.gz : CHECKSUM(SHA256) this package : de4ce0cbece5e76678b973f2eb6e4cd5a22b2fbaae952ddec86a09e77fd03dbb CHECKSUM(SHA256) upstream package : de4ce0cbece5e76678b973f2eb6e4cd5a22b2fbaae952ddec86a09e77fd03dbb https://raw.github.com/willb/sbt-packaging/master/sbt : CHECKSUM(SHA256) this package : 20d1be8114324dfc73cd86e5685f389e378c7468412b3386b2d6311b884960e6 CHECKSUM(SHA256) upstream package : 20d1be8114324dfc73cd86e5685f389e378c7468412b3386b2d6311b884960e6 http://repo1.maven.org/maven2/org/apache/ivy/ivy/2.3.0/ivy-2.3.0.pom : CHECKSUM(SHA256) this package : c3cd46443b1b1296cd78ad3b8d96b48e8b55c04060db9c2e217896f86245df88 CHECKSUM(SHA256) upstream package : c3cd46443b1b1296cd78ad3b8d96b48e8b55c04060db9c2e217896f86245df88 Jar and class files in source ----------------------------- ./sbt-0.13.1/sbt/src/sbt-test/source-dependencies/canon/lib/a.jar ./sbt-0.13.1/sbt/src/sbt-test/source-dependencies/canon/actual/a.jar Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1055799 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG Approval awaiting FPC consideration -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review