[Bug 1062162] Review Request: sunxi-tools - Tools to help hacking Allwinner (sunxi) based devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1062162



--- Comment #5 from Hans de Goede <hdegoede@xxxxxxxxxx> ---
Good:

- rpmlint checks return:
sunxi-tools.src: W: invalid-url Source0: sunxi-tools.tar.gz
sunxi-tools.x86_64: W: no-manual-page-for-binary fex2bin
sunxi-tools.x86_64: W: no-manual-page-for-binary pio
sunxi-tools.x86_64: W: no-manual-page-for-binary fel
sunxi-tools.x86_64: W: no-manual-page-for-binary bootinfo
sunxi-tools.x86_64: W: no-manual-page-for-binary usb-boot
sunxi-tools.x86_64: W: no-manual-page-for-binary nand-part
sunxi-tools.x86_64: W: no-manual-page-for-binary fel-gpio
3 packages and 0 specfiles checked; 0 errors, 8 warnings.
 These can all be ignored
- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv2+) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

Everything looks good, approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]