https://bugzilla.redhat.com/show_bug.cgi?id=1060465 --- Comment #3 from Petr Šabata <psabata@xxxxxxxxxx> --- Items marked as TODO are optional but recommended fixes; FIX are review blockers. TODO: Drop the BuildRoot tag unless you plan to push this into EPEL5 too. This is no longer needed. TODO: The same applies to line 31 (rm -rf $RPM_BUILD_ROOT) and the whole %clean section. TODO: Remove %defattr, this is no longer required, not even in EPEL. TODO: I think the same applies to removing empty directories on line 36. TODO: Utilize DESTDIR instead of PERL_INSTALL_ROOT, line 33. TODO: Package the `examples' directory in %doc. TODO: Remove META.json from %doc; this file is of no use to the end users. Dependencies: You'll need to BuildRequire all the use'd and require'd modules to prevent possible future build failures caused by buildroot changes. FIX: BR perl TODO: BR perl(autouse) FIX: BR perl(Carp) TODO: BR perl(Date::Calc) -- this is an optional test dependency TODO: BR perl(Date::Manip) -- ditto FIX: BR perl(Encode) FIX: BR perl(Exporter) TODO: BR perl(File::Basename) FIX: BR perl(File::Copy) FIX: BR perl(File::Find) TODO: BR perl(integer) TODO: BR perl(IO::File) FIX: BR perl(lib) FIX: BR perl(List::Util) TODO: BR perl(strict) FIX: BR perl(Test::More) TODO: BR perl(utf8) TODO: BR perl(warnings) FIX: Drop the perl(Test::Simple) BR, it's not used anywhere. TODO: You (run-) require specific versions of Archive::Zip and File::Temp. You should filter out the unversioned automatically detected requires from the resulting RPM. This page will tell you how to achieve that: https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering FIX: Your changelog entry is malformed. Use one of the formats mentioned in the guidelines: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Changelogs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review