https://bugzilla.redhat.com/show_bug.cgi?id=1060915 --- Comment #6 from Gerard Ryan <gerard@xxxxxxx> --- Spec URL: http://galileo.fedorapeople.org/aether-connector-okhttp/0.0.11-1/aether-connector-okhttp.spec SRPM URL: http://galileo.fedorapeople.org/aether-connector-okhttp/0.0.11-1/aether-connector-okhttp-0.0.11-1.fc21.src.rpm Hi Gil, thanks for the review. Sorry to waste your time with the issues. I think I've got them sorted now: (In reply to gil cattaneo from comment #3) > - Bundled jar/class files should be removed before build > Note: Jar files in source (see attachment) > See: http://fedoraproject.org/wiki/Packaging:Java#Pre- > built_JAR_files_.2F_Other_bundled_software' > Please, remove > aether-connector-okhttp-92f183b496e7d628d50f07339d4880d4efffbc70/src/test/ > files/aether-spi-0.9.0.M2.jar Done. > [!]: If (and only if) the source package includes the text of the license(s) > in its own file, then that file, containing the text of the license(s) > for the package is included in %doc. > > aether-connector-okhttp-92f183b496e7d628d50f07339d4880d4efffbc70/license- > header.txt I've included this now, but should this file be included? It's not what I would consider "the text of the license". > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses found: > "Apache (v2.0)", "Unknown or generated". 64 files have unknown license. > Detailed output of licensecheck in /home/gil/1060915-aether-connector- > okhttp/licensecheck.txt > > Apache (v2.0) and EPLv1.0 > aether-connector-okhttp-92f183b496e7d628d50f07339d4880d4efffbc70/src/main/ > java/io/tesla/aether/okhttp/ssl/CertificateUtils.java > aether-connector-okhttp-92f183b496e7d628d50f07339d4880d4efffbc70/src/main/ > java/io/tesla/aether/okhttp/ssl/SslContextFactory.java > > Apache (v2.0) > aether-connector-okhttp-92f183b496e7d628d50f07339d4880d4efffbc70/src/main/ > java/io/tesla/aether/wagon/OkHttpsWagon.java > I've removed/unbundled the first two here, and added jetty-util as a dep. The last is Apache and EPL also, even though it's just reported as Apache here. I've changed the license field to: EPL and (ASL 2.0 and EPL). I think this is now correct, isn't it? > [?]: Package contains no bundled libraries without FPC exception. > I've removed the io/tesla/aether/okhttp/ssl/ package since the 2 files there were forked from jetty-util. > [!]: If the source package does not include license text(s) as a separate > file > from upstream, the packager SHOULD query upstream to include it. > Please open a bug to include it https://github.com/tesla/aether-connector-okhttp/pull/1 > [!]: Package does not include license text files separate from upstream. As I understand it, we'll still need to include EPL until upstream accept it. Is this correct or should I remove it? (In reply to gil cattaneo from comment #4) > Please FIX aether-connector-okhttp.noarch: W: > incoherent-version-in-changelog 1.2.1-1 ['0.0.10-0.1.fc21', '0.0.10-0.1'] Done. (In reply to gil cattaneo from comment #5) > Now is available aether-connector-okhttp 0.0.11. > Please consider upgrading Done. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review