https://bugzilla.redhat.com/show_bug.cgi?id=1053222 --- Comment #5 from Lokesh Mandvekar <lsm5@xxxxxxxxxx> --- (In reply to Matthew Miller from comment #4) > Finally getting around to the review -- sorry. > > /usr/share/fedora-dockerfiles needs to be owned by the package (list %dir > %dir %{_datadir}/%{name} in the %files) > > Not necessary, but it might be cleaner to do the install part in a loop. Sure thing. I'll put up a new version after Scott updates upstream. > > Also: the auto-picked up deps on /bin/bash and /bin/sh are spurious, since > those scripts are executed inside the container. I think that making the > scripts not executable will fix that (although I'm not sure that the RUN > command will still work?). So maybe filter out the deps with RPM kludges -- > or else make whatever Dockerfile modifications are needed so the scripts can > be shipped nonexecutable. (That actually makes most sense to me because they > could theoretically actually be disastrous if run on the host accidentally.) So the current Dockerfiles seem to handle chmod +x by themselves so I think we can -x scripts by default. If that's agreeable, Scott please see my PR for -x on scripts on your github repo :) > > Question for Scott: do we want to do GPLv2 or a more permissive license? > Although it's some amount of overhead, it might be nice to clarify the > license specifically in each Dockerfile (or at least each subdirectory); > this gives us some room to use different possibly-conflicting licenses for > different contributions in the future. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review