[Bug 1046992] Review Request: rubygem-gemnasium-parser - Safely parse Gemfiles and gemspecs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1046992

Ken Dreyer <ktdreyer@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-cvs?



--- Comment #3 from Ken Dreyer <ktdreyer@xxxxxxxxxxxx> ---
Thanks very much for the review! (And apologies for the delayed response.)
You're right about the macros in the changelog. I've fixed them:
http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-gemnasium-parser.git/commit/?id=5b2d0c2398796d9091ea998dab87abcc01d8346e

Regarding the tests, I modified the package so that they'll still run, but will
not block the build. This will give greater visibility on failures:
http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-gemnasium-parser.git/commit/?id=4d6d6a47f182e371ec64edf4895d7f450c58e64d

I guess that's the best we can do for now. Thanks again.

New Package SCM Request
=======================
Package Name: rubygem-gemnasium-parser
Short Description: Safely parse Gemfiles and gemspecs
Owners: ktdreyer
Branches: f20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]