https://bugzilla.redhat.com/show_bug.cgi?id=1036393 Matej Stuchlik <mstuchli@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #5 from Matej Stuchlik <mstuchli@xxxxxxxxxx> --- (In reply to Jakub Dorňák from comment #4) > To be honest, I have listed the directories just because I was asked to do > it in another review (#1036396). > It is probably aimed to ensure that every new directory in future versions, > which may possibly be bundled library, requires packager's attention. I see. Not what I do, but it can't hurt I s'ppose. Looking at the %check output [0], I think it would be good to add python3-django and python3-httplib2 to BuildRequires (and eventually the others as well, once they get python3 package), so that the tests working with those will be executed too, however these tests currently fail. From what I can tell it seems to be caused by incorrect/incomplete porting of the tests to python3, so it's not that big of a deal. The spec looks fine otherwise, so I'll APPROVE this, but please try to resolve this. [0] http://kojipkgs.fedoraproject.org//work/tasks/8585/6488585/build.log -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review