[Bug 1048815] Review Request: RdRand - A library and a tool for the asm instruction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1048815

Dan Horák <dan@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dan@xxxxxxxx



--- Comment #6 from Dan Horák <dan@xxxxxxxx> ---
few issues in the package to fix
- use ExclusiveArch: %{ix86} x86_64 instead of ExcludeArch, there is no chance
Intel instructions will work somewhere else
- drop the %clean section, %defattr in %files and "rm -rf $RPM_BUILD_ROOT" in
%build, it's all done by rpm since F-12 and EL-6
- use an empty line as a delimiter of changelog entries
- drop the BuildRequires: autoconf libtool - all required files are already in
the source archive and they shouldn't be regenerated during build

and one more general note - you shouldn't include the autotools' temporary
outputs like the autom4te.cache and .deps directories, generated Makefile, etc
in the git tree (and source archive)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]