https://bugzilla.redhat.com/show_bug.cgi?id=1058812 --- Comment #8 from Jakub Hrozek <jhrozek@xxxxxxxxxx> --- Thanks for the changes. The package now looks good and builds fine. There is one more change I'd like to see before I approve the package. The spec file explicitly requires dbus-libs, but that's not necessary, RPM does the right thing on its own: $ rpm -qp --requires /home/remote/jhrozek/rpmbuild/RPMS/x86_64/mod_lookup_identity-0.8.2-1.fc20.x86_64.rpm | grep dbus dbus-libs libdbus-1.so.3()(64bit) (the former is explicit, the latter autogenerated) actually even rpmdiff warns about the explicit requires: $ rpmlint /home/remote/jhrozek/rpmbuild/RPMS/x86_64/mod_lookup_identity-0.8.2-1.fc20.x86_64.rpm mod_lookup_identity.x86_64: E: explicit-lib-dependency dbus-libs mod_lookup_identity.x86_64: W: spelling-error %description -l en_US lookup -> lockup, hookup, look up The second warning is a false positive. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review