Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-mecab - Perl binding for MeCab https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233424 ------- Additional Comments From rc040203@xxxxxxxxxx 2007-04-01 01:26 EST ------- Needswork: - MUSTFIX: No License, no copyright inside of the source tarball. Spec file claims to be BSD/LGPL/GPL, but their no indication inside of the sources for this claim, and their website is unreadable to me (seemingly written in Japanese). - MUSTFIX: Specfile contains: %{!?python_sitearch: ...} I fail to understand why a perl module's spec would want python_sitearch - MUSTFIX: Package doesn't acknowledge RPM_OPT_FLAGS ExtUtils::MakeMaker Makefiles don't use CXXFLAGS, they use OPTIMIZE => %{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="${RPM_OPT_FLAGS}" - MUSTFIX: Package explictly links against -lstdc++ This is a bug in mecap-config libstdc++ is an internal implementation detail of g++ which must not be explictily used. - SHOULDFIX: %check ||: The ||: in check is an anachronism to cater ancient versions of rpm and should not be used. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review