https://bugzilla.redhat.com/show_bug.cgi?id=1058038 --- Comment #10 from Jeff Backus <jeff.backus@xxxxxxxxx> --- (In reply to Pavol Ipoth from comment #7) > I uploaded src.rpm and tar.gz files with setup.py. Yes i am considering > support of EPEL5 (no not in VM) Please provide output of Koji builds for each Fedora/EPEL version you are going to support - especially EPEL since it supports additional architectures. I think you'll be fine, but just to be certain. Also, I took a look at the latest version of the spec. Thanks for making so many fixes! I have some more comments, however: * %description field is still > 80 characters. Please break into multiple lines, preferably between "tape" and "devices". * Please change "%files" in %changelog to just files. Don't use macros unless you actually want them to be expanded. * Support files that aren't meant to be executed on their own should not have the hash-bang at the top. Please remove the #!/usr/bin/python from them. * Consider creating a manpage for the executable. Some of us old codgers still heavily rely on man and apropos to find things. :) * Use either tabs or spaces for indention, but don't use both. Line 51 is using spaces but you've used tabs everywhere else. A nitpick, yes, but still a requirement. * Since you have a setup.py now (good catch Christopher!), please consider adding a %build section: %build setup.py build * Also consider changing %install section to rely on setup.py as much as possible. The following will put most of your files in the right place: setup.py install --install-purelib=%{buildroot}%{python_sitelib} - You will still need to create/copy files that do not go into %{python_sitelib}. - It will also build and install an egg-info file in %{python_sitelib}. You'll need to add a corresponding entry to your %files sectino. * Version in setup.py does not match package version (1.0 != 1.2). This especially matters with regard to the egg-info. Regards, Jeff -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review