https://bugzilla.redhat.com/show_bug.cgi?id=1058163 --- Comment #1 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- A few initial comments: 0. rpmlint mostly clean, just cosmetic: $ rpmlint *.rpm glmark2.src:85: W: mixed-use-of-spaces-and-tabs (spaces: line 85, tab: line 1) 1 packages and 0 specfiles checked; 0 errors, 1 warnings. please fix. 1. SHOULD omit deprecated Group: tag (unless you intend to support old rpm versions, like whats in rhel5) 2. what's the justification/rationale for all the subpackages? Could this be simplified into a single package? If continuing with keeping things split up, please include justification in a .spec comment. 3. MUST omit these extraneous BuildRequires: BuildRequires: libstdc++ BuildRequires: gcc-c++ see https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 3. SHOULD simplify subpackage handling to not use -n, for example, from %package -n glmark2-assets to %package assets and %files -n glmark2-assets to %files assets 4. MUST improve Summary for -assets subpkg, Summary: Benchmark for OpenGL 2.0 (while we're at it, consider using a more conventional subpkg name, like -common) 5. MUST use versioned subpkg dependencies, for example, use Requires: %{name}-assets = %{version}-%{release} instead of Requires: glmark2-assets for similar reason(s) as outlined here: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Requiring_Base_Package 6. SHOULD consider using virtual/compat BuildRequires: libjpeg-devel instead of BuildRequires: libjpeg-turbo-devel since it really only wants any libjpeg, not libjpeg-turbo specifically (or does it?) Similarly, consider more-compatible BuildRequires: pkgconfig(libpng12) instead of BuildRequires: libpng12-devel -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review