https://bugzilla.redhat.com/show_bug.cgi?id=1058038 Jeff Backus <jeff.backus@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeff.backus@xxxxxxxxx --- Comment #1 from Jeff Backus <jeff.backus@xxxxxxxxx> --- Hi Pavol, I have performed an **INFORMAL** review of your package. Unfortunately, I have not ascended into the hallowed halls of the Proven Packager yet, so I cannot do a formal review. Hopefully it still will be helpful. I have additional notes at the bottom. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel Python packages require a BuildRequires entry. In your case, you need: BuildRequires: python2-devel See: https://fedoraproject.org/wiki/Packaging:Python#BuildRequires ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 44 files have unknown license. License field matches LICENSE file. [!]: Package requires other packages for directories it uses. Note: No known owner of /etc/systeminfo, /usr/lib64/python2.7/site- packages/systeminfo [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/python2.7/site- packages/systeminfo, /etc/systeminfo In %files section change the following: %config(noreplace) %{_sysconfdir}/%{name}/* %{python_sitearch}/%{name}/* to: %config(noreplace) %{_sysconfdir}/%{name} %{python_sitearch}/%{name} [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. Please refer to: https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required Please wrap in %if 0%{?rhel} && 0%{?rhel} <= 5 <...> %endif statements Ex: %if 0%{?rhel} && 0%{?rhel} <= 5 rm -rf %{buildroot} %endif See: https://fedoraproject.org/wiki/Packaging:Python#Macros [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [!]: Spec file is legible and written in American English. A few notes: - Please change fibre to fiber - "enviroments" misspelled. - Please format the %description field such that lines do not exceed 80 characters. Refer to %description field description in: https://fedoraproject.org/wiki/How_to_create_an_RPM_package#SPEC_file_overview - Please consider placing each Requires entry on its own line. Not requirement, but it does make it more legible. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. Please consider creating a -doc subpackage and including the HTML documentation that is included in the source tarball. [!]: Package complies to the Packaging Guidelines See notes above and below. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python See notes above and below. [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Buildroot is not present Note: Invalid buildroot found: %{_tmppath}/%{name}-%{version}-%{release} See: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag Please wrap BuildRoot in %if 0%{?rhel} && 0%{?rhel} <= 5 <...> %endif statements Ex: %if 0%{?rhel} && 0%{?rhel} <= 5 BuildRoot: %{_tmppath}/%{name}-%{version}-%{release} %endif [!]: Dist tag is present (not strictly required in GL). [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Upstream LICENSE file included. [x]: Final provides and requires are sane (see attachments). [!]: Package functions as described. Program failed as follows on an x86_64 running Fedora 20: $ sudo systeminfo --get system Traceback (most recent call last): File "/bin/systeminfo", line 259, in <module> main() File "/bin/systeminfo", line 157, in main getattr(asset, action)(options) File "/usr/lib64/python2.7/site-packages/systeminfo/proc/base.py", line 92, in summary getattr(self, options['get_data_action'])(options) File "/usr/lib64/python2.7/site-packages/systeminfo/proc/system.py", line 74, in getData core_enabled_count += iteminfo[1] TypeError: unsupported operand type(s) for +=: 'int' and 'NoneType' [!]: Latest version is packaged. I'm assuming this is true, however I cannot find an official release tarball or even release tags at above URL. [x]: Package does not include license text files separate from upstream. [!]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments Please change Source field to include URL to release tarball. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. Package is marked as noarch and built without problems on my x86_64. [-]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. Consider using: * non-executable files: install -pm 0644 <source file(s)> <dest dir> * executable files: install -pm 0755 <source file(s)> <dest dir> Also consider using install -d <dest dir> instead of mkdir -p. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: systeminfo-1.2-1.noarch.rpm systeminfo-1.2-1.src.rpm systeminfo.noarch: W: spelling-error %description -l en_US hw -> he, h, w systeminfo.noarch: W: spelling-error %description -l en_US fibre -> fiber, fire, fib re systeminfo.noarch: W: spelling-error %description -l en_US enviroments -> environments, environment systeminfo.noarch: E: description-line-too-long C This utility is primarily focused on system admin to give quick and nice way to overview hw information. Also includes fibre channel and tape devices, which are heavily used in enterprise enviroments. systeminfo.noarch: E: no-changelogname-tag systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/tapetplparsable.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/fcms.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/tapetplparsable.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/cputplparsable.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/cputplparsable.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/io/file.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/propertytemplate.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/propertytemplate.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/io/file.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/systemtpllong.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/systemtpllong.py 0644L /usr/bin/python systeminfo.noarch: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/systeminfo/view/systemtpllong.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/disktpllong.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/disktpllong.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/fcms.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/pcitplparsable.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/fcms.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/pcitplparsable.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/pcitplparsable.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/pcitplparsable.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/tabletemplate.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/base.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/memorytplshort.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/tapetpldetail.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/tapetplshort.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/base.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/misc/__init__.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/__init__.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/cputpldetail.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/cputpldetail.py 0644L /usr/bin/python systeminfo.noarch: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/systeminfo/view/cputpldetail.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/cputpllong.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/headertabletemplate.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/cputpllong.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/pcitpldetail.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/misc/__init__.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/disktplshort.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/systemtpldetail.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/tapetplshort.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/tapetplshort.py 0644L /usr/bin/python systeminfo.noarch: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/systeminfo/view/tapetplshort.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/pcitpllong.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/systemtpldetail.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/cpu.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstpldetail.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstpldetail.py 0644L /usr/bin/python systeminfo.noarch: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstpldetail.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/systemtplparsable.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/systemtplparsable.py 0644L /usr/bin/python systeminfo.noarch: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/systeminfo/view/systemtplparsable.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/tapetpldetail.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/memorytpldetail.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/memory.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/memorytpldetail.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/cputplshort.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/cputplshort.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/base.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/misc/config.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/tapetpllong.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/misc/config.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/tapetpllong.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/__init__.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/io/__init__.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/pcitpldetail.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/memorytpllong.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/memorytpllong.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/io/__init__.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/disktplshort.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/disktplshort.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/tape.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/memorytplshort.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/tape.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/disk.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/memorytplshort.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/memorytplshort.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstpllong.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/disk.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstpllong.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/disk.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/memorytplparsable.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/memorytplparsable.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstplshort.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/tabletemplate.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/__init__.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/tabletemplate.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/__init__.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/__init__.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/cpu.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/disktpldetail.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstplshort.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/io/file.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/memorytpllong.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/memorytpllong.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/disktpldetail.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/voidtemplate.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/__init__.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/tapetpldetail.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/tapetpldetail.py 0644L /usr/bin/python systeminfo.noarch: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/systeminfo/view/tapetpldetail.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/disktpldetail.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/disktpldetail.py 0644L /usr/bin/python systeminfo.noarch: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/systeminfo/view/disktpldetail.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/systemtpldetail.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/systemtpldetail.py 0644L /usr/bin/python systeminfo.noarch: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/systeminfo/view/systemtpldetail.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/pcitpldetail.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/pcitpldetail.py 0644L /usr/bin/python systeminfo.noarch: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/systeminfo/view/pcitpldetail.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstplparsable.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/propertytemplate.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/cputpldetail.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/pci.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/cpu.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/io/__init__.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/pci.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/cputpldetail.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/cputplparsable.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/memorytplparsable.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstplshort.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstplshort.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/memorytplparsable.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/__init__.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/cputplparsable.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/misc/config.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/cputplshort.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/systemtplshort.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/pcitpllong.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/pcitpllong.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/pcitplshort.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/pcitplshort.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/systemtplparsable.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/cputplshort.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/systemtplshort.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/headertabletemplate.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/system.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/tapetplparsable.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/tapetplparsable.py 0644L /usr/bin/python systeminfo.noarch: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/systeminfo/view/tapetplparsable.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/system.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/systemtplshort.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/systemtplshort.py 0644L /usr/bin/python systeminfo.noarch: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/systeminfo/view/systemtplshort.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstpldetail.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/headertabletemplate.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/systemtpllong.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/systemtpllong.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/misc/config-prod.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/pcitpllong.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/disktpllong.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/disktpllong.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/tapetpllong.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/tapetpllong.py 0644L /usr/bin/python systeminfo.noarch: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/systeminfo/view/tapetpllong.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstplparsable.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/voidtemplate.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/pci.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstpllong.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstpllong.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/voidtemplate.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/__init__.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/cputpllong.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/cputpllong.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/pcitplshort.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/pcitplshort.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/__init__.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/__init__.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/disktplshort.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstpldetail.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/misc/__init__.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/tapetplshort.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/system.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstplparsable.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstplparsable.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/tape.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/memorytpldetail.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/memorytpldetail.py 0644L /usr/bin/python systeminfo.noarch: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/systeminfo/view/memorytpldetail.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/systemtplparsable.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/disktplparsable.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/disktplparsable.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/misc/config-prod.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/misc/config-prod.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/disktplparsable.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/memory.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/__init__.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/__init__.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/disktplparsable.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/memory.pyc systeminfo.noarch: W: no-manual-page-for-binary systeminfo systeminfo.src: W: spelling-error %description -l en_US hw -> he, h, w systeminfo.src: W: spelling-error %description -l en_US fibre -> fiber, fire, fib re systeminfo.src: W: spelling-error %description -l en_US enviroments -> environments, environment systeminfo.src: E: description-line-too-long C This utility is primarily focused on system admin to give quick and nice way to overview hw information. Also includes fibre channel and tape devices, which are heavily used in enterprise enviroments. systeminfo.src: E: no-changelogname-tag systeminfo.src: W: no-%build-section systeminfo.src: W: invalid-url Source0: systeminfo-1.2.tar.gz 2 packages and 0 specfiles checked; 192 errors, 9 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint systeminfo systeminfo.noarch: W: spelling-error %description -l en_US hw -> he, h, w systeminfo.noarch: W: spelling-error %description -l en_US fibre -> fiber, fire, fib re systeminfo.noarch: W: spelling-error %description -l en_US enviroments -> environments, environment systeminfo.noarch: E: description-line-too-long C This utility is primarily focused on system admin to give quick and nice way to overview hw information. Also includes fibre channel and tape devices, which are heavily used in enterprise enviroments. systeminfo.noarch: E: no-changelogname-tag systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/tapetplparsable.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/fcms.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/tapetplparsable.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/cputplparsable.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/cputplparsable.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/io/file.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/propertytemplate.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/propertytemplate.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/io/file.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/systemtpllong.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/systemtpllong.py 0644L /usr/bin/python systeminfo.noarch: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/systeminfo/view/systemtpllong.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/disktpllong.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/disktpllong.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/fcms.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/pcitplparsable.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/fcms.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/pcitplparsable.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/pcitplparsable.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/pcitplparsable.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/tabletemplate.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/base.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/memorytplshort.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/tapetpldetail.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/tapetplshort.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/base.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/misc/__init__.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/__init__.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/cputpldetail.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/cputpldetail.py 0644L /usr/bin/python systeminfo.noarch: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/systeminfo/view/cputpldetail.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/cputpllong.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/headertabletemplate.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/cputpllong.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/pcitpldetail.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/misc/__init__.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/disktplshort.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/systemtpldetail.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/tapetplshort.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/tapetplshort.py 0644L /usr/bin/python systeminfo.noarch: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/systeminfo/view/tapetplshort.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/pcitpllong.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/systemtpldetail.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/cpu.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstpldetail.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstpldetail.py 0644L /usr/bin/python systeminfo.noarch: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstpldetail.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/systemtplparsable.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/systemtplparsable.py 0644L /usr/bin/python systeminfo.noarch: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/systeminfo/view/systemtplparsable.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/tapetpldetail.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/memorytpldetail.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/memory.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/memorytpldetail.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/cputplshort.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/cputplshort.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/base.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/misc/config.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/tapetpllong.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/misc/config.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/tapetpllong.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/__init__.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/io/__init__.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/pcitpldetail.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/memorytpllong.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/memorytpllong.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/io/__init__.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/disktplshort.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/disktplshort.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/tape.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/memorytplshort.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/tape.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/disk.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/memorytplshort.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/memorytplshort.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstpllong.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/disk.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstpllong.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/disk.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/memorytplparsable.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/memorytplparsable.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstplshort.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/tabletemplate.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/__init__.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/tabletemplate.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/__init__.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/__init__.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/cpu.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/disktpldetail.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstplshort.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/io/file.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/memorytpllong.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/memorytpllong.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/disktpldetail.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/voidtemplate.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/__init__.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/tapetpldetail.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/tapetpldetail.py 0644L /usr/bin/python systeminfo.noarch: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/systeminfo/view/tapetpldetail.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/disktpldetail.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/disktpldetail.py 0644L /usr/bin/python systeminfo.noarch: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/systeminfo/view/disktpldetail.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/systemtpldetail.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/systemtpldetail.py 0644L /usr/bin/python systeminfo.noarch: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/systeminfo/view/systemtpldetail.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/pcitpldetail.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/pcitpldetail.py 0644L /usr/bin/python systeminfo.noarch: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/systeminfo/view/pcitpldetail.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstplparsable.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/propertytemplate.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/cputpldetail.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/pci.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/cpu.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/io/__init__.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/pci.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/cputpldetail.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/cputplparsable.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/memorytplparsable.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstplshort.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstplshort.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/memorytplparsable.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/__init__.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/cputplparsable.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/misc/config.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/cputplshort.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/systemtplshort.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/pcitpllong.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/pcitpllong.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/pcitplshort.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/pcitplshort.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/systemtplparsable.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/cputplshort.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/systemtplshort.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/headertabletemplate.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/system.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/tapetplparsable.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/tapetplparsable.py 0644L /usr/bin/python systeminfo.noarch: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/systeminfo/view/tapetplparsable.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/system.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/systemtplshort.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/systemtplshort.py 0644L /usr/bin/python systeminfo.noarch: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/systeminfo/view/systemtplshort.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstpldetail.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/headertabletemplate.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/systemtpllong.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/systemtpllong.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/misc/config-prod.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/pcitpllong.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/disktpllong.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/disktpllong.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/tapetpllong.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/tapetpllong.py 0644L /usr/bin/python systeminfo.noarch: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/systeminfo/view/tapetpllong.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstplparsable.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/voidtemplate.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/pci.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstpllong.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstpllong.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/voidtemplate.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/__init__.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/cputpllong.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/cputpllong.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/pcitplshort.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/pcitplshort.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/__init__.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/template/__init__.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/disktplshort.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstpldetail.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/misc/__init__.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/tapetplshort.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/system.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstplparsable.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/fcmstplparsable.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/tape.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/memorytpldetail.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/memorytpldetail.py 0644L /usr/bin/python systeminfo.noarch: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/systeminfo/view/memorytpldetail.py systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/systemtplparsable.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/disktplparsable.py systeminfo.noarch: E: non-executable-script /usr/lib64/python2.7/site-packages/systeminfo/view/disktplparsable.py 0644L /usr/bin/python systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/misc/config-prod.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/misc/config-prod.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/disktplparsable.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/memory.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/__init__.pyc systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/__init__.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/view/disktplparsable.pyo systeminfo.noarch: E: noarch-python-in-64bit-path /usr/lib64/python2.7/site-packages/systeminfo/proc/memory.pyc systeminfo.noarch: W: no-manual-page-for-binary systeminfo 1 packages and 0 specfiles checked; 190 errors, 4 warnings. # echo 'rpmlint-done:' Requires -------- systeminfo (rpmlib, GLIBC filtered): /usr/bin/python config(systeminfo) python python(abi) python-dbus python-dmidecode python-gudev Provides -------- systeminfo: config(systeminfo) systeminfo Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -n systeminfo Buildroot used: fedora-20-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG Additional Notes ================ * Please look into how to run fedora-review for yourself. I have found it immensely helpful and instructive. See: https://fedoraproject.org/wiki/Package_Review_Process#Reviewer * Please add BuildRequires: python2-devel * Please add a %changelog section. See: https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs * Change Release to 1%{?dist}. See https://fedoraproject.org/wiki/How_to_create_an_RPM_package#SPEC_file_overview * URL for released source? * Remove BuildArch tag -> using python_sitearch instead of python_sitelib. See: https://fedoraproject.org/wiki/Packaging:Python#Macros * One Requires entry per line. * Restrict %description to 80 character lines. See: https://fedoraproject.org/wiki/How_to_create_an_RPM_package#SPEC_file_overview * Change %config(noreplace) %{_sysconfdir}/%{name}/* to %config(noreplace) %{_sysconfdir}/%{name} * Change %{python_sitearch}/%{name}/* to %{python_sitearch}/%{name} * Consider making a -doc package to include HTML documentation * Spelling errors: - fibre -> fiber (specs must be US English) - enviroments -> environments * Wrap the following in %if 0%{?rhel} && 0%{?rhel} <= 5 <...> %endif statements - BuildArch - rm -rf %{buildroot} - See: https://fedoraproject.org/wiki/Packaging:Python#Macros * Consider using install -pm 0644 <source> <dest> or install -pm 0755 <src> <dest> instead of cp -pR * Consider using install -d <dest dir> instead of mkdir -p. * I found the command-line help a little hard to read with all of the additional white-space. My preference (by no means a requirement) would be to use fewer blank lines. * Package does not work on my machine: $ sudo systeminfo --get system Traceback (most recent call last): File "/bin/systeminfo", line 259, in <module> main() File "/bin/systeminfo", line 157, in main getattr(asset, action)(options) File "/usr/lib64/python2.7/site-packages/systeminfo/proc/base.py", line 92, in summary getattr(self, options['get_data_action'])(options) File "/usr/lib64/python2.7/site-packages/systeminfo/proc/system.py", line 74, in getData core_enabled_count += iteminfo[1] TypeError: unsupported operand type(s) for +=: 'int' and 'NoneType' Some of the above are repeated in the review phase - sorry. I'll be happy to clarify anything that isn't clear. Regards, Jeff -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review