Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tecnoballz - A Breakout like game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234563 j.w.r.degoede@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |j.w.r.degoede@xxxxxx CC|j.w.r.degoede@xxxxxx | Flag| |fedora-review? ------- Additional Comments From j.w.r.degoede@xxxxxx 2007-03-30 15:25 EST ------- Looks good overal, however: Must FIX: --------- * This form of the cache scriptlets is no longer used: " touch --no-create %{_datadir}/icons/hicolor || : if [ -x %{_bindir}/gtk-update-icon-cache ]; then %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || : fi " instead the guidelines / scriptlets page now says: " touch --no-create %{_datadir}/icons/hicolor || : %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || : " Please change this to the new form. * If you use sgid games, then you must make sure the game drops the additonal rights ASAP, see: http://fedoraproject.org/wiki/SIGs/Games?action=show&redirect=Extras%2FSIGs%2FGames#head-367e7208aacfec8f8aff1b34c1795e43c0967ecd if you need help with this let me know. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review